Skip to content

Fix new manual expense flow regressions (Part 3) - #98405

Open
thelullabyy wants to merge 5 commits into
Expensify:mainfrom
thelullabyy:fix-existing-regressions/93854
Open

Fix new manual expense flow regressions (Part 3)#98405
thelullabyy wants to merge 5 commits into
Expensify:mainfrom
thelullabyy:fix-existing-regressions/93854

Conversation

@thelullabyy

@thelullabyy thelullabyy commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #98230
$ #98317
$ #98240
PROPOSAL:

Tests

Verify that all of these issues are not reproducible
$ #98230
$ #98317
$ #98240

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that all of these issues are not reproducible
$ #98230
$ #98317
$ #98240

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
98230.mov
98317.mov
98240.mov

@thelullabyy thelullabyy changed the title Fix existing regressions/93854 Fix new manual expense flow regressions Aug 12, 2026
@thelullabyy thelullabyy changed the title Fix new manual expense flow regressions Fix new manual expense flow regressions (Part 3) Aug 12, 2026
@codecov

codecov Bot commented Aug 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/SCREENS.ts 100.00% <ø> (ø)
src/hooks/useDefaultParticipants.ts 100.00% <100.00%> (ø)
src/libs/IOUUtils.ts 80.22% <100.00%> (+0.30%) ⬆️
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 66.66% <ø> (ø)
src/libs/ReportUtils.ts 86.97% <100.00%> (-0.04%) ⬇️
src/libs/actions/Policy/Rules.ts 51.77% <100.00%> (+21.33%) ⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx 73.91% <100.00%> (-0.08%) ⬇️
src/setup/index.ts 100.00% <100.00%> (ø)
src/types/form/MerchantRuleForm.ts 0.00% <ø> (ø)
... and 11 more
... and 20 files with indirect coverage changes

@thelullabyy
thelullabyy marked this pull request as ready for review August 12, 2026 11:15
@thelullabyy
thelullabyy requested review from a team as code owners August 12, 2026 11:15
@thelullabyy

thelullabyy commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@melvin-bot
melvin-bot Bot requested review from ikevin127 and joekaufmanexpensify and removed request for a team August 12, 2026 11:16
@melvin-bot

melvin-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@thelullabyy thelullabyy mentioned this pull request Aug 12, 2026
Open
7 tasks
thelullabyy
thelullabyy commented Aug 12, 2026
View reviewed changes
Comment thread src/libs/Navigation/OnyxTabNavigator.tsx
const persistSelectedTab = Tab.setSelectedTab as (tabID: string, tabName: string) => void;
const notifyTabSelected = onTabSelected as (newTabName: string | undefined) => void;

useEffect(() => {

@thelullabyy thelullabyy Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this issue #98240,

On the first Manual press:

  1. tabPress fires and is not prevented (no discard guard involved).
  2. The tab navigator's own state moves to index 0 → manual.
  3. The parent never takes that change — the URL stays /create/track/start/1/0/scan.
  4. The navigator is then re-hydrated from the parent's pre-press snapshot and snaps back to scan, with no dispatch, no remount, and no Navigation.* call.

The second press works because by then the parent's snapshot has caught up

Solution: We record what each press asked for (from → to), and if the navigator's state later drifts back to the tab we came from

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: fa66c27073

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@trjExpensify

trjExpensify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@ikevin127 can you prioritise the review of this today, please? Thanks!

joekaufmanexpensify
joekaufmanexpensify approved these changes Aug 12, 2026
View reviewed changes

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing deploy blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joekaufmanexpensify joekaufmanexpensify joekaufmanexpensify approved these changes
@ikevin127 ikevin127 Awaiting requested review from ikevin127

Assignees

@thelullabyy thelullabyy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thelullabyy @trjExpensify @joekaufmanexpensify