fix(whispering): disable webkit hardware acceleration under remote di…#2314
Open
Adityakk9031 wants to merge 1 commit into
Open
fix(whispering): disable webkit hardware acceleration under remote di…#2314Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKitGTK crashes with SIGILL (Illegal Instruction) when the app is launched inside an XRDP or VNC session on Ubuntu 24.04. The crash happens because the compositing and DMABUF renderer paths attempt to execute hardware-accelerated GPU instructions; software rasterizers like llvmpipe JIT-compile code that exercises instruction set extensions the virtualized CPU does not support, and the process terminates before the webview initializes.
The fix sets WEBKIT_DISABLE_COMPOSITING_MODE and WEBKIT_DISABLE_DMABUF_RENDERER at process start on Linux when the environment signals a remote or virtual display: presence of XRDP_SESSION, VNCSESSION, a non-zero DISPLAY socket (:1, :10, etc.), or XDG_SESSION_CLASS=remote. Both variables are skipped when already set by the user, so anyone who wants to override the behavior still can.
Closes #2082.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.