chore: pin bun install linker to isolated#2140
Closed
braden-w wants to merge 3 commits into
Closed
Conversation
The setup screen wore the narrow max-w-lg centered shape meant for the capture column, so a tall setup card sat stranded beside ~560px of dead horizontal space and, with sm:py-0, hugged the top and bottom window edges. Split the first-run branch into a two-column grid: a left value-prop column (hero plus Private/On-device/Open-source trust items) beside the existing setup card on the right, stacking to a single column below lg. The hero is now a shared snippet so the capture view keeps its centered single-column layout. Columns are top-aligned so the headings share a line, and the container always keeps vertical padding so content never touches the window edges.
…state The empty state passed class="py-8", but .cn-empty is scoped as .style-vega .cn-empty (specificity 0,2,0, unlayered) and already applies p-12, so the utility never took effect. Remove the no-op class.
bun's default linker varies by bun version, workspace setup, and lockfile configVersion, so the node_modules layout differed across machines and could flip silently on a bun upgrade. Pin it explicitly so every machine and CI produce the same isolated (pnpm-style) tree, where a package can only import the dependencies it declares.
Member
Author
|
Splitting this PR. The bunfig pin moved to #2152, which is a clean one-commit PR containing only the The two whispering onboarding commits here (drop dead padding class, redesign onboarding as two-column) are superseded by #2141, which is built on top of them and replaces the two-column layout with single-column. The onboarding work ships through #2141 instead, so it should not merge via this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a root
bunfig.tomlpinning the bun install linker toisolated(pnpm-style).Why
bun's default linker varies by bun version, workspace setup, and the lockfile
configVersion, so thenode_moduleslayout was diverging across machines and could flip silently on a bun upgrade.That already bit us.
onnxruntime-webis a transitive dependency of@ricky0123/vad-web, not declared by whispering, so it is unreachable from the app root under an isolated tree. Whispering's vite config resolved it from the app root and threwMODULE_NOT_FOUNDat config-eval time on an isolated machine while working fine on a hoisted one. The resolution path was fixed separately (resolve onnx through vad-web); this pins the layout so the hoisted-vs-isolated divergence stops happening across machines and CI.isolatedis the strict layout: a package can only import the dependencies it declares, so phantom dependencies fail loudly instead of riding on accidental hoisting.Note
This is repo-wide. The quality check on this PR exercises a full install and build under isolated. If another app was relying on a hoisted phantom dependency, it surfaces here rather than on
main.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.