fix(opensidian): use Backquote key code for terminal shortcut#1860
Open
Gautam-aman wants to merge 2 commits into
Open
fix(opensidian): use Backquote key code for terminal shortcut#1860Gautam-aman wants to merge 2 commits into
Gautam-aman wants to merge 2 commits into
Conversation
Author
|
I've opened a PR for this issue. The fix updates terminal shortcut detection to use KeyboardEvent.code ("Backquote") instead of KeyboardEvent.key, which should improve reliability for Cmd + ` on macOS. Please let me know if you'd like me to adjust the approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes terminal toggle shortcut detection on macOS.
The terminal shortcut handler currently checks
KeyboardEvent.key === '\'when handlingCmd +/`Ctrl +. On some macOS keyboard layouts and configurations, thekeyvalue may differ even though the physical backquote key is pressed.This change switches the shortcut detection to use
KeyboardEvent.code === 'Backquote', which is layout-independent and consistently identifies the physical backquote key.Changes
e.key === '\'withe.code === 'Backquote'` in the terminal shortcut handler.metaKey(macOS Command key) andctrlKey.Why
The UI and onboarding text indicate that
⌘ + \`` should toggle the terminal, but users have reported that onlyCtrl + ``works. UsingKeyboardEvent.codeprovides more reliable shortcut detection across macOS keyboard layouts.Fixes #1718
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.