fix: todo of notification extension detection#1564
Open
sarthakNITT wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements real browser-extension presence detection for the Whispering web notification service by using a postMessage ping/pong handshake, replacing the previous stubbed “always false” behavior.
Changes:
- Add
postMessage-based extension detection with a 200ms timeout in the web notification service. - Update
bun.lockdependency resolutions (notablydetect-libcentries).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/whispering/src/lib/services/notifications/web.ts | Replaces the extension-detection stub with a ping/pong postMessage mechanism. |
| bun.lock | Updates lockfile entries related to detect-libc resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
detectExtensionstub with a real postMessage ping/pong postswhispering-extension-pingto the page and waits 200ms for a whispering-extension-pong reply from a content script, falling back to the browser Notification API if none arrives.Follow-up: wiring the actual extension notification send path once a content script ships.
Closes #1563