mlir: add enzyme.atomic_rmw op with ordering attribute#2950
Open
pengmai wants to merge 1 commit into
Open
Conversation
wsmoses
reviewed
Jul 15, 2026
| AtomicRMWKindAttr:$kind, | ||
| AtomicOrdering:$ordering, | ||
| AnyType:$value, | ||
| Arg<AnyMemRef, "the reference to rmw", [MemRead, MemWrite]>:$memref, |
Member
There was a problem hiding this comment.
Can we also preserve the alignment here (though I suppose we could just have alignment as a generic setAttr call)
wsmoses
reviewed
Jul 16, 2026
| enzyme::AtomicRMWOp::create( | ||
| builder, loadOp.getLoc(), gradient.getType(), | ||
| arith::AtomicRMWKind::addf, Ordering::monotonic, gradient, | ||
| memrefGradient, indices); |
Member
There was a problem hiding this comment.
we also need to do the same for the enzyme::AffineAtomicRMWOp too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.