FullReduceTransposeReshape rewrite#2631
Open
Pangoraw wants to merge 1 commit into
Open
Conversation
wsmoses
approved these changes
Jul 16, 2026
wsmoses
left a comment
wsmoses
left a comment
Member
There was a problem hiding this comment.
LGTM in a quick look but you should also have avik give it a once over too
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
- Coverage 31.73% 31.12% -0.62%
==========================================
Files 227 227
Lines 44908 44870 -38
==========================================
- Hits 14253 13964 -289
- Misses 30655 30906 +251 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes EnzymeAD/Reactant.jl#3039.
The pattern was invalid if the transformation was not the same on both sides of a binary op.