Extensive tests for Multi - #520
Merged
Merged
Conversation
sloorush
requested changes
Aug 6, 2026
sloorush
left a comment
sloorush
left a comment
Member
There was a problem hiding this comment.
Looks like there are some things that should not be in this repo like multi/apl/mtest and multi/ewc-fixes other than that the tests look fabulous.
We should make the launching consistent with the original demo application.
Member
|
Ready to be merged but the multi app needs to be moved to ewc side in a folder called |
Member
|
OWUM has some regressions because of this. Need to recheck.
|
Adds ways to watch the Multi-mode suite run, and fixes four harness bugs found while doing so. - multitests:step click through a test via Next/End buttons - multitests:watch slowed down tests with visible windows Can also be triggered by setting OBSERVE, STEP_MODE, etc - these are conveniences
The onTimeout fix was verified against an rsync'd copy under the session
scratchpad, which meant the only version of it lived in a temp directory:
invisible, undiffable and disposable. Editing ~/dev/ewc directly would
have been visible and trivially revertable — it is a git repo — and was
the right call.
e2e/multi/ewc-fixes/ now holds:
- onTimeout.aplf the fixed file, as a drop-in replacement
- onTimeout.patch the same change as a unified diff, verified to apply
cleanly to the version on main/arachnophobia/mandelbrot
and to produce a byte-identical result
- README.md both defects, how to apply, how to test a candidate fix
via EWC_SRC, and the EWC-REF caveat for CI
No wss.aplc file is shipped: a better fix for that one already exists on
mandelbrot and arachnophobia, so the README points at it rather than
carrying an inferior duplicate.
It was module state set once and never cleared, so clicking it in the first test ungated the whole run. Cleared in teardown, which every spec's afterEach already calls.
This is just a move
cursork
force-pushed
the
multimode-tests
branch
from
September 9, 2026 08:11
b49ae7f to
8eb661e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517
Confidence in Multi mode needed bolstering. A new test suite has been written. It is separate from the other tests, as it is a distinct problem of its own. Example of running the test suite, in manual step mode (this is automated completely otherwise):
Multi.mov
Requires Dyalog/ewc#140