Skip to content

ENG-1992 Downgrade Obsidian react version to 18 #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trangdoan982 wants to merge 4 commits into
base: main
Choose a base branch
from
+663 −623
Open

ENG-1992 Downgrade Obsidian react version to 18 #1227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab29703
ENG-1992 Downgrade Obsidian react version to 18
trangdoan982 Jul 12, 2026
1d0ffb4
Downgrade only runtime react/react-dom; keep @types/react at 19
trangdoan982 Jul 12, 2026
b009092
Stop hoisting react/react-dom to fix Vercel pruned build
trangdoan982 Jul 12, 2026
7c13533
Revert hoistPattern; keep only the catalog react downgrade
trangdoan982 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/obsidian/src/components/canvas/TldrawViewComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ export const TldrawPreviewComponent = ({
const [isReady, setIsReady] = useState(false);
const [isEditorMounted, setIsEditorMounted] = useState(false);
const isCreatingRelationRef = useRef(false);
const saveTimeoutRef = useRef<NodeJS.Timeout>(null);
const saveTimeoutRef = useRef<NodeJS.Timeout | null>(null);
const isSavingRef = useRef<boolean>(false);
const lastShiftClickRef = useRef<number>(0);
const SHIFT_CLICK_DEBOUNCE_MS = 300; // Prevent double clicks within 300ms
const lastSavedDataRef = useRef<string>("");
const editorRef = useRef<Editor>(null);
const editorRef = useRef<Editor | null>(null);
const plugin = usePlugin();

const customShapeUtils = [
Expand Down
Loading
Loading