ENG-1857 Validate Obsidian importer with Roam-origin nodes#1225
Draft
sid597 wants to merge 1 commit into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1216 /
eng-2019-extract-shared-cross-space-node-discovery-into.This validates and fixes the existing Obsidian shared-node importer for Roam-origin nodes. The importer now:
my_conceptsschema rows before mapping it locallynodeInstanceId, mappednodeTypeId,importedFromRid,lastModified,authorId)Root Cause
Roam-origin shared node markdown does not include the Obsidian-style frontmatter that the importer was previously parsing from
rawContent. That meant the importer could create the file, fail to findnodeTypeId/nodeInstanceId, and then delete the file as invalid.Runtime Proof
Validated through the real Obsidian command, not a stubbed surface:
Discourse Graph: Import nodes from another spacein the Obsidian plugin.eng1890testgroups.test-1-graph:[[EVD]] - This is a Evidence page. - {Source}[[CLM]] - cat -1node,0relations, and no new schemas/relations.import/test-1-graph/[[CLM]] - cat -.mdwith mapped frontmatter and the Roam markdown body.Known Limit
The existing Obsidian materializer normalizes source
[[CLM]]into[[CLM|CLM]]. The semantic body and nested bullets are preserved, but byte-for-byte markdown fidelity is still a follow-up concern already covered by ENG-1882.Validation
git diff --checkpnpm --filter @discourse-graphs/obsidian test:unitpnpm --filter @discourse-graphs/obsidian check-typespnpm --filter @discourse-graphs/obsidian buildNote: the local shell still reports the repo's existing engine warning because it is using Node
20.20.2while the package asks for Node>=22; the checks above passed.