Skip to content

server list ping determination bug fix #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MC-Samuel wants to merge 4 commits into
base: dev
Choose a base branch
from
+22 −1
Open

server list ping determination bug fix #2831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2245af
fixes to ServerListPingScriptEventPaperImpl
MC-Samuel Jul 2, 2026
e3eab34
changed excluded player calculation
MC-Samuel Jul 9, 2026
0ed6f7a
moved to a separate determination
MC-Samuel Jul 12, 2026
9cbc05d
add back automatically setting number of players with `exclude_player…
MC-Samuel Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .../main/java/com/denizenscript/denizen/paper/events/ServerListPingScriptEventPaperImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.destroystokyo.paper.profile.PlayerProfile;
import com.destroystokyo.paper.profile.ProfileProperty;
import net.md_5.bungee.api.ChatColor;
import org.apache.commons.lang3.mutable.MutableInt;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.profile.PlayerTextures;
Expand Down Expand Up @@ -70,6 +71,17 @@ public ServerListPingScriptEventPaperImpl() {
ListedPlayersEditor.setListedPlayerInfo(evt.getEvent(), text);
return true;
});
this.<ServerListPingScriptEventPaperImpl, ElementTag>registerOptionalDetermination("player_count", ElementTag.class, (evt, context, input) -> {
if (!CoreConfiguration.allowRestrictedActions) {
Debug.echoError("Cannot use 'player_count' in list ping event: 'Allow restricted actions' is disabled in Denizen config.yml.");
return false;
}
if (input.isInt()) {
evt.getEvent().setNumPlayers(input.asInt());
return true;
}
return false;
});
}

public PaperServerListPingEvent getEvent() {
Expand All @@ -86,7 +98,15 @@ public static void setListedPlayerInfo(PaperServerListPingEvent event, List<Stri
}

public static void excludeListedPlayers(PaperServerListPingEvent event, Set<UUID> exclude) {
event.getListedPlayers().removeIf(listedPlayerInfo -> exclude.contains(listedPlayerInfo.id()));
MutableInt counter = new MutableInt();
event.getListedPlayers().removeIf(listedPlayerInfo -> {
if (exclude.contains(listedPlayerInfo.id())) {
counter.increment();
return true;
}
return false;
});
event.setNumPlayers(event.getNumPlayers() - counter.intValue());

@tal5 tal5 Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but missing one check:
If a plugin modified the player count to something else already we don't want to mess with that, so should start by checking if NumPlayers is the same as listed.size(), and only decrease NumPlayers if it is.

}
}

Expand Down
1 change: 1 addition & 0 deletions plugin/src/main/java/com/denizenscript/denizen/events/server/ListPingScriptEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public class ListPingScriptEvent extends BukkitScriptEvent implements Listener {
// "VERSION_NAME:<ElementTag>" to change the server's version name (only on Paper).
// "EXCLUDE_PLAYERS:<ListTag(PlayerTag)>" to exclude a set of players from showing in the player count or preview of online players (only on Paper).
// "ALTERNATE_PLAYER_TEXT:<ListTag>" to set custom text for the player list section of the server status (only on Paper). (Requires "Allow restricted actions" in Denizen/config.yml). Usage of this to present lines that look like player names (but aren't) is forbidden.
// "PLAYER_COUNT:<ElementTag(Number)>" to set the amount of players that are online (only on Paper). (Requires "Allow restricted actions" in Denizen/config.yml). Usage of this to display a higher number of players than are actually connected is forbidden.
// "MOTD:<ElementTag>" to change the MOTD that will show.
//
// -->
Expand Down