ci: verify NMS interaction classes are packaged - #418
Open
gamingjovi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a CI check to verify that the distributable DecentHolograms jar contains the NMS classes required for entity and hologram interactions.
A Paper 26.2 server running DecentHolograms 2.10.1 produced the following disconnect when attacking a hologram:
The affected class exists in the source tree and is referenced by the 26.2 inbound packet handler, so this adds a packaging regression check rather than changing interaction behavior.
CI now verifies that the final plugin jar contains:
NmsEntityInteractAction.classNmsEntityInteractEvent.classv26_2/InboundPacketHandler.classIf any of these runtime classes are missing from the distributable jar, the build will fail instead of allowing an incomplete artifact to be published.