Skip to content

Fix OpenFeature provider hook test isolation #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leoromanovsky wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −13
Open

Fix OpenFeature provider hook test isolation #12178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions ...agging/feature-flagging-api/src/test/java/datadog/trace/api/openfeature/ProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
Expand All @@ -24,7 +25,6 @@
import dev.openfeature.sdk.EventDetails;
import dev.openfeature.sdk.Features;
import dev.openfeature.sdk.FlagEvaluationDetails;
import dev.openfeature.sdk.Hook;
import dev.openfeature.sdk.OpenFeatureAPI;
import dev.openfeature.sdk.ProviderEvaluation;
import dev.openfeature.sdk.ProviderEvent;
Expand All @@ -33,7 +33,6 @@
import dev.openfeature.sdk.exceptions.FatalError;
import dev.openfeature.sdk.exceptions.ProviderNotReadyError;
import java.lang.reflect.Field;
import java.util.List;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
Expand Down Expand Up @@ -327,25 +326,34 @@ protected Class<?> loadEvaluatorClass() throws ClassNotFoundException {

@Test
public void testGetProviderHooksReturnsFlagEvalHook() {
Provider provider =
new Provider(new Options().initTimeout(10, MILLISECONDS), mock(Evaluator.class));
List<Hook> hooks = provider.getProviderHooks();
assertThat(hooks.size(), equalTo(1));
assertThat(hooks.get(0) instanceof FlagEvalHook, equalTo(true));
final Evaluator evaluator = mock(Evaluator.class);
final Provider providerWithoutSpanEnrichment =
new Provider(new Options(), evaluator, Boolean.FALSE);
final Provider providerWithSpanEnrichment =
new Provider(new Options(), evaluator, Boolean.TRUE);

assertHasFlagEvalHook(providerWithoutSpanEnrichment);
assertHasFlagEvalHook(providerWithSpanEnrichment);
}

@Test
public void testShutdownCleansUpMetrics() throws Exception {
Evaluator evaluator = mock(Evaluator.class);
public void testShutdownCleansUpEvaluator() throws Exception {
final Evaluator evaluator = mock(Evaluator.class);
when(evaluator.initialize(eq(10L), eq(MILLISECONDS), any())).thenReturn(true);
when(evaluator.hasConfiguration()).thenReturn(true);
Provider provider = new Provider(new Options().initTimeout(10, MILLISECONDS), evaluator);
final Provider provider =
new Provider(new Options().initTimeout(10, MILLISECONDS), evaluator, Boolean.FALSE);

provider.initialize(null);
provider.shutdown();

verify(evaluator).shutdown();
// After shutdown, getProviderHooks still returns a list (hook is still present but metrics is
// shut down)
assertThat(provider.getProviderHooks().size(), equalTo(1));
}

private static void assertHasFlagEvalHook(final Provider provider) {
assertTrue(
provider.getProviderHooks().stream().anyMatch(FlagEvalHook.class::isInstance),
"flag evaluation metrics hook should be registered");
}

public interface EvaluateMethod<E> {
Expand Down
Loading