[redis-ha] Add dataVolumeOverride and statefulSetSuffix for PVC/StatefulSet name customization#411
Open
hardy6413 wants to merge 4 commits into
Open
[redis-ha] Add dataVolumeOverride and statefulSetSuffix for PVC/StatefulSet name customization#411hardy6413 wants to merge 4 commits into
hardy6413 wants to merge 4 commits into
Conversation
Signed-off-by: hardy6413 <irreftw@gmail.com>
Signed-off-by: hardy6413 <irreftw@gmail.com>
Signed-off-by: hardy6413 <irreftw@gmail.com>
Signed-off-by: hardy6413 <irreftw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds two values so you can control what the StatefulSet and its PVCs are named:
dataVolumeOverride(defaultdata) - renames the/datavolume, which isalso the prefix of the PVC name.
statefulSetSuffix(defaultserver) - the suffix on the StatefulSet name(
<fullname>-<statefulSetSuffix>).Because of that it is possible to have a custom pvc/chart name. Additionally this pr fixes a bug in
restore-redisinit container. Previously with a hardcodedgrep -q 'ha-server-0'. That only works if thename ends in
ha, so it's already broken today for anyone usingfullnameOverrideor
nameOverrideChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])