Patch inactive user issue in V2 API - #3610
Open
momo3404 wants to merge 4 commits into
Open
Conversation
- Function checks if resource owner is active and present before authorization, and returns error if not - Move code assigning resource_owner to this new function for better readability
Generated by 🚫 Danger |
Contributor
|
One test is breaking and it must be because you are calling |
momo3404
force-pushed
the
momo/v2-api-inactive-user-patch
branch
2 times, most recently
from
August 11, 2026 20:05
bd50e66 to
d78fe3a
Compare
aaronskiba
reviewed
Aug 12, 2026
| ) | ||
| end | ||
|
|
||
| def render_error(errors:, status:, details: nil) |
Contributor
There was a problem hiding this comment.
Could this be private?
You are assigning @payload[:error] but that is not yet defined in app/views/api/v2/error.json.jbuilder.
Maybe you could also refactor handle_internal_server_error and handle_client_not_authorized to also call render_error?
momo3404
force-pushed
the
momo/v2-api-inactive-user-patch
branch
from
August 19, 2026 19:08
a36d4f2 to
d8e7b47
Compare
momo3404
force-pushed
the
momo/v2-api-inactive-user-patch
branch
from
August 19, 2026 19:09
aca6673 to
94b0533
Compare
momo3404
force-pushed
the
momo/v2-api-inactive-user-patch
branch
from
August 19, 2026 19:44
c68b1b7 to
b0a3361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
authorize_resource_ownerfunction to V2base_api_controllerthat checks if user is active and present before authorization.render_errorfunction to V2 API.base_controller_specfor V2base_api_controller