Enable duct cutouts for fuel tank vessels - #1426
Open
MarAlder wants to merge 8 commits into
Open
Conversation
Contributor
PR RemindersThis PR has changes in
This is an automated reminder from CI |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
+ Coverage 73.27% 73.30% +0.02%
==========================================
Files 324 324
Lines 28642 28659 +17
==========================================
+ Hits 20987 21008 +21
+ Misses 7655 7651 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MarAlder
marked this pull request as ready for review
August 20, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable duct cutouts for fuel tank vessels
Description
Ducts were only subtracted from fuselages and wings.
CCPACSVesselbuilt its loft directly inBuildLoft(), so vessels neither participated in the cutout mechanism nor reacted to the duct cutout flag. Configurations with a duct passing through a tank could not be represented.Since a tank can be composed of multiple vessels
CCPACSDucts::LoftWithDuctCutouts()gained an overload taking several uIDs; the vessel passes its own uID and that of its parent fuel tank. The existing single-uID overload delegates to it, so fuselage and wing behaviour is unchanged.ℹ️ As a side refactoring, the corrupt tank was moved from
simpletest-fuelTanks.cpacs.xmlinto a separatesimpletest-invalid-fuelTanks.cpacs.xmlwith its ownInvalidFuelTanksfixture (similar to tests for systems and decks).Closes #1416
How Has This Been Tested?
simpletest-fuelTanks.cpacs.xmlgained three ducts: one running through both the section-based (tank1) and the parametric vessels (tank3), and two that lie entirely inside a vessel but are excluded, one by the vessel uID (tank1_outerVessel), one by the fuel tank uID (tank3).The tests in
tiglTanks.cppcover the cutout flag, unchanged volumes while disabled, the cut volumes, exact restoration after toggling back, solid validity viaBRepCheck_Analyzer, the added faces, both exclusion levels, and propagation toCCPACSFuelTank.On the Python side,
test_fuelTanks.pycovers the bindings only: reachingCCPACSDuctsfrom the configuration, bothLoftWithDuctCutouts()overloads, the new one with a Python list, and the cutout flag via the TiGL API cross-checked againstCCPACSDucts::IsEnabled(). The list argument requiresstd::vector<std::string>to be instantiated in SWIG, whichcommon.idid not do; the added%template(StringVector)also makesCPACSUIDSequence::GetUIDs()iterable from Python.Screenshots, that help to understand the changes (if applicable):
Checklist for PR Author:
ChangeLog.mdupdated