Skip to content

Naca5 #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HannahGedler wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Naca5 #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
8117582
deletet some whitelines
Mar 20, 2026
2fe0760
erster entwurf
Mar 23, 2026
0c7668a
gespeicherter versuch
Mar 23, 2026
94bd978
code runs without errors (but it does not work)
Mar 24, 2026
db94f2d
experimented with the tests
Mar 25, 2026
65cb334
changed the tests a bit
Mar 25, 2026
5180cb2
added a coordinate test
Mar 27, 2026
c5d3c55
end of the 3rd phase
Jun 22, 2026
b539ba9
refined the if statements
Jun 23, 2026
6a1370e
if the camberline is dividd by 8 the error is not soo big anymore
Jun 24, 2026
7c0b2dd
trial and error
Jun 25, 2026
265ca86
corrected the variable name from k2/k1
Jun 25, 2026
804b75d
it works nowgit status+ the k1/k2 isnt calculated anymore, constatnts…
Jun 26, 2026
47656bf
changes from before the vacation
Jul 6, 2026
11a953a
implementd the upperlowerwire
Jul 7, 2026
749d883
Merge remote-tracking branch 'origin/main' into NACA5
Jul 15, 2026
31b008f
trying to implement structs (not working yet)
Jul 16, 2026
488234c
the code runs now with structs, the test pass
Jul 17, 2026
76bf172
changed the name from CTiglNACA4Calculator to CTiglNACACalculator
Jul 17, 2026
219993e
forgot to commit the renamed files
Jul 17, 2026
dd8be8f
Remove old testNACA4Calculator.cpp after rename
Jul 17, 2026
fd49391
refactored python test (uses now NACA4DigitCode)
Jul 17, 2026
0686e65
added the tigl_export makro to the NACA4DigitCode and 5DigitCode
Jul 17, 2026
e4ec311
added a direct from xml test and added in the calculator the use of C…
Jul 21, 2026
c4181be
Merge branch 'main' into NACA5
Jul 23, 2026
a162579
fixed the includes and the namespace
Jul 23, 2026
4bee53d
fixed a missing bracket, three tests still fail
Jul 23, 2026
40e5a2a
added the namespace leParam and the use in the upper/lower_curve
Jul 23, 2026
d615a96
delteted from one testname the 4
Jul 23, 2026
ddbdfc1
fixed error in nacacalculator: use p for if conditions with NACA4
Jul 27, 2026
5bd0935
status before cleaning up
Aug 3, 2026
a328962
more code cleanup, everything works
Aug 10, 2026
1145a27
removed an uneccessary test
Aug 11, 2026
8559ee2
before renaming naca4upper/lower curve
Aug 12, 2026
add0716
renamed naca4upper/lowercurve to nacaupper/lowercurve
Aug 12, 2026
73218bf
i dont know if this is also in the repo (because the files did not s…
Aug 18, 2026
71c3f0a
removed some comments
Aug 18, 2026
8b35206
cleaning up the header files
Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bindings/python_internal/configuration.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
#include "generated/CPACSAtaChapterList.h"
#include "CTiglWingProfileNACA.h"
#include "generated/CPACSNacaProfile.h"
#include "CTiglNACA4Calculator.h"
#include "CTiglNACACalculator.h"
#include "CPACSNacaProfile.h"
#include "CCPACSDeck.h"
#include "generated/CPACSDecks.h"
Expand Down Expand Up @@ -598,7 +598,7 @@ class CCPACSWingRibsPositioning;
%include "generated/CPACSCurvePointListXYZ.h"
%include "CCPACSCurvePointListXYZ.h"
%include "generated/CPACSProfileGeometry.h"
%include "CTiglNACA4Calculator.h"
%include "CTiglNACACalculator.h"
%include "generated/CPACSNacaProfile.h"
%include "CCPACSWingProfile.h"
%include "CCPACSFuselageProfile.h"
Expand Down
238 changes: 0 additions & 238 deletions src/wing/CTiglNACA4Calculator.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading