Skip to content

1284 implement rounded wing segments - #1338

Open
merakulix wants to merge 44 commits into
mainfrom
1284_implement_rounded_wing_segments
Open

1284 implement rounded wing segments#1338
merakulix wants to merge 44 commits into
mainfrom
1284_implement_rounded_wing_segments

Conversation

@merakulix

@merakulix merakulix commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR provides a new lofting algorithm that enables TiGL to build shapes with rounded segments from given profile curves and rounding distances.

Description

A new class was added implementing the new lofting algorithm:

CTiglRoundedSegmentSurface,

Within given (rounding) distances to each side of a profile curve, the curve will be rounded within this distance, otherwise it will be linear.

The xsd-Schema was updated, to implement the new functionality for CPACS.
The customized CPACS classes were updated to call the new lofting algortihm.

Implements #1284

How Has This Been Tested?

Added unit test file and new testdata.
Tested visually, see below:

Screenshots, that help to understand the changes(if applicable):

Wing is rounded around the middle section, using the new lofting algorithm:

image

Wing not rounded, using the usual algorithm
image

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Reminders

This PR has changes in src/, tests/unittests/, and bindings/python_internal/ but not in TIGLCreator/, tests/integrationtests/, or tests/python/. ChangeLog.md has changes.

  • ✅ Tests added or not required
  • ✅ Python bindings modified
  • ✅ ChangeLog.md updated

This is an automated reminder from CI

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.71053% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.33%. Comparing base (d205ea1) to head (9d7ea76).

Files with missing lines Patch % Lines
src/geometry/CTiglMakeLoft.cpp 91.89% 3 Missing ⚠️
src/geometry/CTiglRoundedSegmentSurface.cpp 96.15% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
+ Coverage   73.20%   73.33%   +0.12%     
==========================================
  Files         324      326       +2     
  Lines       28604    28756     +152     
==========================================
+ Hits        20939    21087     +148     
- Misses       7665     7669       +4     
Flag Coverage Δ
unittests 73.33% <96.71%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/geometry/CTiglRoundedSegmentSurface.h 100.00% <100.00%> (ø)
src/wing/CTiglWingBuilder.cpp 90.24% <100.00%> (+1.83%) ⬆️
src/geometry/CTiglRoundedSegmentSurface.cpp 96.15% <96.15%> (ø)
src/geometry/CTiglMakeLoft.cpp 80.21% <91.89%> (+2.88%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@merakulix
merakulix force-pushed the 1284_implement_rounded_wing_segments branch from 15677de to 9ef14a9 Compare July 8, 2026 15:41
@merakulix
merakulix marked this pull request as ready for review July 8, 2026 15:47
@merakulix
merakulix force-pushed the 1284_implement_rounded_wing_segments branch from e8f341b to 5d8662c Compare July 13, 2026 08:39
@merakulix
merakulix requested a review from joergbrech July 13, 2026 08:41
@merakulix
merakulix force-pushed the 1284_implement_rounded_wing_segments branch from 92599d5 to 9d7ea76 Compare August 6, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants