1284 implement rounded wing segments - #1338
Open
merakulix wants to merge 44 commits into
Open
Conversation
Contributor
PR RemindersThis PR has changes in
This is an automated reminder from CI |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
+ Coverage 73.20% 73.33% +0.12%
==========================================
Files 324 326 +2
Lines 28604 28756 +152
==========================================
+ Hits 20939 21087 +148
- Misses 7665 7669 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
merakulix
force-pushed
the
1284_implement_rounded_wing_segments
branch
from
July 8, 2026 15:41
15677de to
9ef14a9
Compare
merakulix
marked this pull request as ready for review
July 8, 2026 15:47
merakulix
force-pushed
the
1284_implement_rounded_wing_segments
branch
from
July 13, 2026 08:39
e8f341b to
5d8662c
Compare
…egment lofting algorithm
merakulix
force-pushed
the
1284_implement_rounded_wing_segments
branch
from
August 6, 2026 12:47
92599d5 to
9d7ea76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a new lofting algorithm that enables TiGL to build shapes with rounded segments from given profile curves and rounding distances.
Description
A new class was added implementing the new lofting algorithm:
CTiglRoundedSegmentSurface,
Within given (rounding) distances to each side of a profile curve, the curve will be rounded within this distance, otherwise it will be linear.
The xsd-Schema was updated, to implement the new functionality for CPACS.
The customized CPACS classes were updated to call the new lofting algortihm.
Implements #1284
How Has This Been Tested?
Added unit test file and new testdata.
Tested visually, see below:
Screenshots, that help to understand the changes(if applicable):
Wing is rounded around the middle section, using the new lofting algorithm:
Wing not rounded, using the usual algorithm

Checklist: