Skip to content

Add CCPACSSkin to Python bindings - #1041

Open
joergbrech wants to merge 13 commits into
mainfrom
1037-fix
Open

Add CCPACSSkin to Python bindings#1041
joergbrech wants to merge 13 commits into
mainfrom
1037-fix

Conversation

@joergbrech

@joergbrech joergbrech commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Fixes #1037

Description

This PR adds the missing#include and %include statements to the swig interface file configuration.i. It makes the CTiglStringerFrameBorderedObject ctor SWIG-friendly and removes the corresponding %ignore from configuration.i. It fixes the Test CPACS file and adds a Python test.

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Not applicable.

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@codecov

codecov Bot commented Dec 3, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.26%. Comparing base (3615fbd) to head (53235c8).

Files with missing lines Patch % Lines
src/fuselage/CTiglStringerFrameBorderedObject.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
- Coverage   73.28%   73.26%   -0.03%     
==========================================
  Files         324      324              
  Lines       28642    28652      +10     
==========================================
  Hits        20991    20991              
- Misses       7651     7661      +10     
Flag Coverage Δ
unittests 73.26% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fuselage/CTiglStringerFrameBorderedObject.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joergbrech
joergbrech marked this pull request as draft January 2, 2025 10:31
@merakulix

Copy link
Copy Markdown
Contributor

Short update: CCPACSkin is available now via Python Bindings, CPACSSkinSegments as well. I also tested some of the getter functions of boost::optional types in CCPACSFuselageStructure, such as stringers, frames, cargo_cross_beams, cargo_cross_beam_struts, which are also available now. As discussed with @joergbrech, see RISCSoftware/cpacs_tigl_gen#59 about the getter functions for the vector elements

@joergbrech
joergbrech changed the base branch from tigl-3-4-1 to main September 10, 2025 13:44
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

PR Reminders

This PR has changes in src/, tests/python/, and bindings/python_internal/ but not in TIGLCreator/, tests/unittests/, or tests/integrationtests/. ChangeLog.md has changes.

  • 💡 Tip: Consider adding a unit or integration test

This is an automated reminder from CI

@joergbrech
joergbrech marked this pull request as ready for review August 25, 2026 07:37
@joergbrech
joergbrech requested a review from merakulix August 25, 2026 07:37
@joergbrech

Copy link
Copy Markdown
Contributor Author

This PR collected some dust, sorry for that. I finally got around to finishing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several fuslage python bindings seem to be broken

2 participants