You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds the missing#include and %include statements to the swig interface file configuration.i. It makes the CTiglStringerFrameBorderedObject ctor SWIG-friendly and removes the corresponding %ignore from configuration.i. It fixes the Test CPACS file and adds a Python test.
How Has This Been Tested?
Screenshots, that help to understand the changes(if applicable):
Not applicable.
Checklist:
Task
Finished
Reviewer Approved
At least one test for the new functionality was added.
yes
does not apply
OK
New classes have been added to the Python interface.
yes
does not apply
OK
The code is properly documented with doxygen docstrings
❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.26%. Comparing base (3615fbd) to head (53235c8).
Short update: CCPACSkin is available now via Python Bindings, CPACSSkinSegments as well. I also tested some of the getter functions of boost::optional types in CCPACSFuselageStructure, such as stringers, frames, cargo_cross_beams, cargo_cross_beam_struts, which are also available now. As discussed with @joergbrech, see RISCSoftware/cpacs_tigl_gen#59 about the getter functions for the vector elements
This PR has changes in src/, tests/python/, and bindings/python_internal/ but not in TIGLCreator/, tests/unittests/, or tests/integrationtests/. ChangeLog.md has changes.
This PR collected some dust, sorry for that. I finally got around to finishing it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Description
This PR adds the missing
#includeand%includestatements to the swig interface fileconfiguration.i. It makes theCTiglStringerFrameBorderedObjectctor SWIG-friendly and removes the corresponding %ignore fromconfiguration.i. It fixes the Test CPACS file and adds a Python test.How Has This Been Tested?
Screenshots, that help to understand the changes(if applicable):
Not applicable.
Checklist: