Skip to content

Fix gm-unit: dynamically update size_cur when modifying body appearance #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sizzlins wants to merge 3 commits into from
Closed

Fix gm-unit: dynamically update size_cur when modifying body appearance #1582

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc88106
Fix gm-unit: dynamically update size_cur when modifying body appearance
sizzlins Apr 25, 2026
def0dc0
Fix mixed line endings in editor_body.lua for CI
sizzlins Apr 25, 2026
4f34ab4
Refactor body size recalculation to use DRY function
sizzlins Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal/gm-unit/editor_body.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ function Editor_Body_Modifier:setPartModifier(indexList, value)
-- Update the world texture
self.target_unit.flags4.any_texture_must_be_refreshed = true

-- Manually recalculate body size
local new_size = self.target_unit.body.size_info.size_base
local caste = df.creature_raw.find(self.target_unit.race).caste[self.target_unit.caste]
for idx, mod_entry in ipairs(caste.body_appearance_modifiers) do
local t = mod_entry.modifier.type
if t >= 0 and t <= 2 then -- 0=HEIGHT, 1=BROADNESS, 2=LENGTH
local mod_val = self.target_unit.appearance.body_modifiers[idx]
new_size = math.floor((new_size * mod_val) / 100)
end
end
self.target_unit.body.size_info.size_cur = new_size

self:updateChoices()
end

Expand All @@ -45,6 +57,18 @@ function Editor_Body_Modifier:setBodyModifier(modifierIndex, value)
-- Update the world texture
self.target_unit.flags4.any_texture_must_be_refreshed = true

-- Manually recalculate body size

@ab9rf ab9rf Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is an exact duplicate of the code above. write a function and call it in both places. Don't Repeat Yourself.

local new_size = self.target_unit.body.size_info.size_base
local caste = df.creature_raw.find(self.target_unit.race).caste[self.target_unit.caste]
for idx, mod_entry in ipairs(caste.body_appearance_modifiers) do
local t = mod_entry.modifier.type
if t >= 0 and t <= 2 then -- 0=HEIGHT, 1=BROADNESS, 2=LENGTH
local mod_val = self.target_unit.appearance.body_modifiers[idx]
new_size = math.floor((new_size * mod_val) / 100)
end
end
self.target_unit.body.size_info.size_cur = new_size

self:updateChoices()
end

Expand Down