Repro build cleanup#684
Open
dmonakhov wants to merge 3 commits into
Open
Conversation
scgbckbone
reviewed
Jul 13, 2026
dmonakhov
force-pushed
the
repro-build-cleanup
branch
from
July 13, 2026 13:10
d32a1a8 to
b536924
Compare
scgbckbone
reviewed
Jul 13, 2026
| ```shell | ||
| git clone https://github.com/Coldcard/firmware.git | ||
| cd firmware | ||
| git submodule update --init |
Collaborator
There was a problem hiding this comment.
this also should not be needed
Contributor
Author
There was a problem hiding this comment.
It worked for 2026-03-05T2052-v5.5.0, but commit a4ae6c8 has changed submods-match, which was broken and was simply noop.
Just try it yourself
git clone https://github.com/Coldcard/firmware.git
cd firmware
# DOWNLOAD https://coldcard.com/downloads
# get a copy of binary into ./releases/2026-03-05T2052-v5.5.0-mk-coldcard.dfu
git checkout 2026-07-01T1730-v5.5.1
cd stm32
make -f MK-Makefile repro
And it fails like this:
...
HEAD is now at ae885935 New release: 2026-07-01T1730-v5.5.1
Checking submodule revisions: external/micropython external/ckcc-protocol external/mpy-qr external/libngu misc/gpu/external/stm32c0xx_hal_driver misc/gpu/external/cmsis_device_c0
-3d1dfa858beb58b8dac37d8c66d7aed2909812f2 ../external/ckcc-protocol
-537519a829259622ea6b0334fbafd6cae852852f ../external/libngu
-4107246f8a080807b62c3b4838e71e812ea68b6f ../external/micropython
-11347d83f4eb325b10676a4eb8e17deccfe0df44 ../external/mpy-qr
-7e32bf9d8117ee4c8f6a1d138b814fc24bf4c906 ../misc/gpu/external/cmsis_device_c0
-4c5e3e45a8478a33decb1f45d663f485f89c459b ../misc/gpu/external/stm32c0xx_hal_driver
make: *** [shared.mk:180: submods-match] Error 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are trivial cleanups for reproducible build, Commits are tiny so feel free to squash it in to one if required.
TOC
Trivial cleanup for reproducible build examples
Improve check repro human readability
IMHO with explicit csum logging verification becomes more intuitive , see: