Exclude iOS Simulator (Metal) failing validation tests#1773
Draft
CedricGuillemet wants to merge 1 commit into
Draft
Exclude iOS Simulator (Metal) failing validation tests#1773CedricGuillemet wants to merge 1 commit into
CedricGuillemet wants to merge 1 commit into
Conversation
Excludes 22 Playground validation test entries from automatic testing on the Metal backend so the iOS Simulator visualization suite runs to completion: - 'NPE - Angle align': crashes with an MTLVertexDescriptor assertion (attribute references a buffer with no stride) in the particle/instance rendering path, same class as the already-excluded 'Attractors' and 'Particles'. - 21 pixel-comparison failures observed on the iOS Simulator's Metal backend (mostly skinning/animation and shadow paths), each tagged with a reason for follow-up investigation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Playground validation test configuration to allow the iOS Simulator Metal visualization suite to run to completion by skipping known-crashing and known pixel-diff tests on the Metal backend.
Changes:
- Adds
excludedGraphicsApis: ["Metal"]to 22 affected validation entries. - Annotates each newly excluded entry with a
reasonstring describing the observed failure mode for follow-up investigation.
Comment on lines
17
to
21
| "title": "Native Canvas", | ||
| "excludedGraphicsApis": ["Metal"], | ||
| "reason": "iOS Simulator (Metal): NativeCanvas 2D output differs from reference; needs investigation.", | ||
| "playgroundId": "#TKVFSA#8", | ||
| "referenceImage": "native-canvas.png" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes 22 Playground validation test entries from automatic testing on the Metal backend so the iOS Simulator visualization suite runs to completion: