Skip to content

Tighten screenshot comparison coverage #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthargett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tighten screenshot comparison coverage #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Apps/Playground/ReferenceImages/texture-repetition-pbr-material.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Apps/Playground/ReferenceImages/texture-repetition-standard-material.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
36 changes: 26 additions & 10 deletions Apps/Playground/Scripts/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@
"title": "GUI3D SpherePanel",
"playgroundId": "#HB4C01#9",
"renderCount": 50,
"threshold": 80,
"errorRatio": 0.25,
"referenceImage": "spherepanel.png"
},
{
Expand Down Expand Up @@ -1133,16 +1135,15 @@
"title": "GUI Slate",
"playgroundId": "#2YZFA0#277",
"renderCount": 60,
"excludeFromAutomaticTesting": true,
"reason": "Pixel comparison fails (more than 20% pixels differ)",
"errorRatio": 0.1,
"referenceImage": "guiSlate.png"
Comment thread
matthargett marked this conversation as resolved.
},
{
"title": "GUI Near Menu",
"playgroundId": "#2YZFA0#302",
"renderCount": 60,
"excludedGraphicsApis": ["OpenGL"],
"reason": "OpenGL: BGFX FATAL shader compile error in GUI fragment shader ('=' : cannot convert from 'highp float' to 'bool'). Re-enabled on D3D11 post BabylonJS/BabylonNative#1695 (original 'V8 D3D11 crash' no longer reproduces under Chakra; original 'hangs on OpenGL' is now this clean shader-compile failure surfaced by the BabylonJS/BabylonNative#1688 BgfxCallback).",
"threshold": 35,
"errorRatio": 0.25,
"referenceImage": "guiNearMenu.png"
},
{
Expand Down Expand Up @@ -2457,22 +2458,19 @@
{
"title": "GUI Gradient Linear",
"playgroundId": "#XCPP9Y#17227",
"excludeFromAutomaticTesting": true,
"reason": "Pixel comparison fails (more than 20% pixels differ)",
"errorRatio": 1.0,
"referenceImage": "GUI-Gradient-Linear.png"
Comment thread
matthargett marked this conversation as resolved.
},
{
"title": "GUI Gradient Radial",
"playgroundId": "#4Z7EK3",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"errorRatio": 1.0,
"referenceImage": "GUI-Gradient-Radial.png"
},
{
"title": "GUI Gradient Linear with transparency",
"playgroundId": "#PFK1Z5",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"errorRatio": 1.0,
"referenceImage": "GUI-Gradient-Linear-with-transparency.png"
},
{
Expand Down Expand Up @@ -4249,6 +4247,24 @@
"reason": "Pixel comparison fails (more than 20% pixels differ)",
"referenceImage": "Lighting-Volume.png"
},
{
"title": "Texture Repetition - Standard Material",
"playgroundId": "#ESP440#0",
"renderCount": 1,
"errorRatio": 0.1,
"referenceImage": "texture-repetition-standard-material.png",
"excludedEngines": ["webgl1"],
"dependsOn": ["Materials", "Textures"]
},
{
"title": "Texture Repetition - PBR Material",
"playgroundId": "#6EPUUH#0",
"renderCount": 1,
"errorRatio": 1.0,
"referenceImage": "texture-repetition-pbr-material.png",
Comment thread
matthargett marked this conversation as resolved.
"excludedEngines": ["webgl1"],
"dependsOn": ["PBR", "Textures"]
},
{
"title": "Havok FloatingOrigin Multi-Region",
"playgroundId": "#BEDCVY",
Expand Down