Skip to content

Add Velero backup monitoring alerts - #6664

Draft
Adalberto Sampaio (adalrsjr1) wants to merge 4 commits into
Azure:mainfrom
adalrsjr1:ARO-27405
Draft

Add Velero backup monitoring alerts#6664
Adalberto Sampaio (adalrsjr1) wants to merge 4 commits into
Azure:mainfrom
adalrsjr1:ARO-27405

Conversation

@adalrsjr1

Copy link
Copy Markdown
Collaborator

https://redhat.atlassian.net/browse/ARO-27405

WIP -- to be updated

What

Why

Testing

Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.

Describe the testing provided. If you did not add tests, provide a clear
justification.

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

If E2E tests are included:

  • E2E tests follow Principles of Good E2E Test Case Design
  • If new E2E use case is covered (via a new test or new check/verifier),
    demonstrate that the test is able to detect a defect/error and fail with
    proper error message and logs which communicates nature of the problem.

Add PrometheusRule alerts for stuck hourly/daily backups (warning and critical), elevated CSI snapshot and backup deletion failure rates, and a VeleroMetricsAbsent canary. Register the rule file in the SRE HCPs alerting lane.
Add recording rules aggregating CSI snapshot attempts/failures (rate and failure ratio) and backup duration p95. Register the rule file in the HCPs recording-rules lane.
Materialize the Velero backup alerting and recording rules into generatedHCPPrometheusAlertingRules.bicep and generatedHCPRecordingRules.bicep.
Add the Velero backup monitoring User Journey and the Velero backup failures TSG covering the new alerts. Staged copies for review before publishing to eng.ms.
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adalrsjr1
Once this PR has been reviewed and has the lgtm label, please assign hbhushan3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant