Skip to content

feat: prepare MI mock CLI flags in backend - #4242

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
msoriano-prepare-mimock-backend-cliflags
Mar 4, 2026
Merged

feat: prepare MI mock CLI flags in backend#4242
openshift-merge-bot[bot] merged 1 commit into
mainfrom
msoriano-prepare-mimock-backend-cliflags

Conversation

@miguelsorianod

Copy link
Copy Markdown
Collaborator

In #3820 we are going to introduce a validation that interacts with Microsoft's Managed Identities Data Plane service in the ARO-HCP environments where it is available. In the environments where it is not available it is not possible to retrieve credentials associated to Managed Identities. In those environments we instead have a fake implementation of the Managed Identities Data Plane client that always returns the credentials associated to common Azure Service Principal identity that we commonly refer to as the MI mock identity (or MSI Mock identity).

A prerequisite to be able to introduce #3820 is to first rollout the introduction of the CLI flags in the backend binary, so we can later specify them in the Backend's K8s deployment. This MR introduces the MI Mock related CLI flags and basic validation for them.

@miguelsorianod

Copy link
Copy Markdown
Collaborator Author

/hold

Comment thread backend/cmd/root.go Outdated
Comment thread backend/cmd/root.go
Comment thread backend/cmd/root.go
Comment thread backend/cmd/root.go Outdated
@miguelsorianod
Miguel Soriano (miguelsorianod) force-pushed the msoriano-prepare-mimock-backend-cliflags branch from 6cb3f1f to 1d16217 Compare February 27, 2026 16:19
Comment thread backend/cmd/root.go
Comment thread backend/cmd/root.go Outdated
@deads2k

Copy link
Copy Markdown
Collaborator

some weird cruft. Please cleanup one way or the other post-merge

/lgtm
/approve

@miguelsorianod
Miguel Soriano (miguelsorianod) force-pushed the msoriano-prepare-mimock-backend-cliflags branch from 1d16217 to e19daeb Compare February 27, 2026 17:09
@openshift-ci openshift-ci Bot removed the lgtm label Feb 27, 2026
@deads2k

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 27, 2026
@openshift-ci

openshift-ci Bot commented Feb 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, miguelsorianod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miguelsorianod

Copy link
Copy Markdown
Collaborator Author

/hold cancel

@miguelsorianod

Copy link
Copy Markdown
Collaborator Author

/retest

1 similar comment
@raelga

Copy link
Copy Markdown
Collaborator

/retest

@openshift-merge-bot
openshift-merge-bot Bot merged commit baf89f7 into main Mar 4, 2026
18 checks passed
@openshift-merge-bot
openshift-merge-bot Bot deleted the msoriano-prepare-mimock-backend-cliflags branch March 4, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants