Skip to content

Math: Correct epsilon values for close_enough() #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lioncash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Math: Correct epsilon values for close_enough() #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/zeus/Math.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ template <typename E>

[[nodiscard]] bool close_enough(const CVector2f& a, const CVector2f& b, float epsilon = FLT_EPSILON);

[[nodiscard]] inline bool close_enough(float a, float b, double epsilon = FLT_EPSILON) {
[[nodiscard]] inline bool close_enough(float a, float b, double epsilon = DBL_EPSILON) {
return std::fabs(a - b) < epsilon;
}

[[nodiscard]] inline bool close_enough(double a, double b, double epsilon = FLT_EPSILON) {
[[nodiscard]] inline bool close_enough(double a, double b, double epsilon = DBL_EPSILON) {
return std::fabs(a - b) < epsilon;
}
} // namespace zeus