Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new catch block logs only ex.Message (dropping key diagnostics) and includes a potentially misleading comment about load failures being “not a problem.”
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR bumps the package to v5.11.1 and adjusts TestSetUp to be more resilient when preloading assemblies by swallowing Assembly.LoadFrom failures and emitting a diagnostic log entry instead of failing static initialization.
Changes:
- Wrap
Assembly.LoadFrominTestSetUpwith a try/catch to avoid setup failures when a DLL can’t be loaded. - Bump NuGet/package version from 5.11.0 to 5.11.1.
- Add a changelog entry documenting the fix.
File summaries
| File | Description |
|---|---|
| src/UnitTestEx/TestSetUp.cs | Adds try/catch around assembly preloading and logs failures. |
| Common.targets | Increments package version to 5.11.1. |
| CHANGELOG.md | Documents v5.11.1 change. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembly.LoadFrominTestSetUpwith try-catch to log exceptions and prevent setup failures.