Require Node 24 in devEngines so it matches the npm >=11 requirement - #4481
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
sejas
approved these changes
Aug 10, 2026
sejas
left a comment
Member
There was a problem hiding this comment.
@t-hamano , thanks for creating this PR. The change looks good to me. We could even specify the version 24.15.0 which lives in .nvmrc.
@fredrikekelund, I would like to know your opinion about increasing the devEngines node runtime version in package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code investigated the failing
npm install, traced it to the contradiction between the twodevEnginesconstraints, and made the one-line change. I reviewed the reasoning and confirmed the resulting Node/npm resolution locally.Proposed Changes
The two
devEnginesconstraints contradict each other:runtimeallows Node 22, but Node 22 bundles npm 10.9.x, which can never satisfypackageManager: ">=11.0.0". A contributor whose version manager honours the declared runtime floor is blocked from installing at all, with anEBADDEVENGINESerror that blames npm rather than Node. Meanwhile,.nvmrcpins 24.15.0.Testing Instructions
node -vshould report 24.x, andnpm -vshould report 11.x.npm installshould complete withoutEBADDEVENGINES.To see the original failure, switch to
trunkwith a version manager that readsdevEngines(or runnpm installunder Node 22) — the install aborts with the error above.Pre-merge Checklist