Agentic UI: Fix theme-aware Customize shortcuts - #4468
Open
shaunandrews wants to merge 3 commits into
Open
Conversation
shaunandrews
marked this pull request as ready for review
August 6, 2026 19:47
Collaborator
📊 Performance Test ResultsComparing 3e1694b vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
I tested this but I had the following the issue:
- install the block theme theme and confirm the correct controls are displayed
- navigate to the site in the external browser
- install a classic theme like Twenty Thirteen
- go back to the app
- observe that the controls did not update
- try using the controls
- observe the error:
- restart the site
- observe the correct controls
- with the classic UI, it was not necessary to restart the site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI helped separate this bug fix from the larger site-overview prototype and compare the implementation with the existing Classic UI behavior. I reviewed the narrowed diff and verified it independently.
Proposed Changes
Testing Instructions
Automated verification:
npx eslint --fix apps/ui/src/components/site-overview-view/index.test.tsx apps/ui/src/components/site-overview-view/index.tsx apps/ui/src/components/site-overview-view/style.module.css apps/ui/src/data/core/connectors/ipc/index.ts apps/ui/src/data/core/types.ts apps/ui/src/hooks/use-theme-details.tsnpm run typechecknpm test -- apps/ui/src/components/site-overview-view/index.test.tsxnpm run cli:build:uiPre-merge Checklist