Fix i18n extraction silently skipping files that use await using - #4467
Draft
bcotrim wants to merge 1 commit into
Draft
Fix i18n extraction silently skipping files that use await using#4467bcotrim wants to merge 1 commit into
await using#4467bcotrim wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code traced the failure, wrote the fix, and re-ran extraction to verify. I reviewed the diff and the before/after msgid sets myself.
Proposed Changes
wp-babel-makepottranspiles every file with@babel/preset-envbefore extracting, andtransform-block-scopingthrows onawait using. It skipped 9 files, logged the error, and still exited 0 — socode_freezecommitted an incomplete.potand reported success. Long-standing, not a recent regression.code: falseand discards the generated code), so targeting the current Node turns those downlevel transforms off entirely. A repo-level babel config can't fix this: makepot hardcodes its babelcwdto its own package directory and never reads one..pot..potis not regenerated here —code_freezedoes that. Heads-up: the next run shows +472/−8 msgids, of which only 39 come from this fix; the rest is normal drift since the 1.17.0 freeze.Testing Instructions
Before (on
trunk):9
BABEL_TRANSFORM_ERRORblocks, exit code 0.grep -c '^#: apps/cli/commands/config/set.ts:' /tmp/before.pot→0.After — same command with
BROWSERSLIST='current node'prefixed and--output /tmp/after.pot: zero errors, and that samegrep→41. Across all 6 affected files: 0 → 62 call sites, with 0 msgids dropped.Pre-merge Checklist
🤖 Generated with Claude Code