Skip to content

WPDS token fallbacks: clean out various screens (SEO, Newsletter, Scan) - #50634

Merged
simison merged 2 commits into
trunkfrom
update/wpds-fallbacks-leftovers
Jul 17, 2026
Merged

WPDS token fallbacks: clean out various screens (SEO, Newsletter, Scan)#50634
simison merged 2 commits into
trunkfrom
update/wpds-fallbacks-leftovers

Conversation

@simison

@simison simison commented Jul 17, 2026

Copy link
Copy Markdown
Member

Follow up to PRs:

Proposed changes

  • Removes token fallbacks from various screens (SEO, Newsletter, Scan)
  • Adds folders to "no fallbacks" lint rule list

These are already built by pipelines which add fallbacks, so there's no difference in output bundles.

There were a few incorrect fallbacks already, now corrected:

Token Was Official
--wpds-color-foreground-content-neutral-weak #757575, #4d5156, #787c82 #707070
--wpds-color-background-surface-neutral #f6f7f7, #f0f2f5 #fcfcfc
--wpds-color-stroke-surface-neutral-weak #dadde1, #e0e0e0 #f0f0f0

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Smoke test relevant UIs.
  • Confirm bundles stay the same apart from incorrect fallbacks now corrected

@simison
simison requested a review from a team as a code owner July 17, 2026 15:55
@simison simison added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] Ready to Merge Go ahead, you can push that green button! [Feature] SEO Tools Tools for improving a site's search engine optimization. [Feature] Backups Build [Package] Backup [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Feature] Scan [Package] Newsletter [Package] Seo [Package] Scan labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/wpds-fallbacks-leftovers branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/wpds-fallbacks-leftovers

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison
simison force-pushed the update/wpds-fallbacks-leftovers branch from 26951be to 0f0f9d4 Compare July 17, 2026 16:14
@simison simison changed the title WPDS token fallbacks: clean out various screens (SEO, Newsletter, Scan, Backup) WPDS token fallbacks: clean out various screens (SEO, Newsletter, Scan) Jul 17, 2026
@simison simison removed [Feature] Backups [Package] Backup [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. labels Jul 17, 2026
@simison
simison merged commit 4a8d406 into trunk Jul 17, 2026
80 of 81 checks passed
@simison
simison deleted the update/wpds-fallbacks-leftovers branch July 17, 2026 16:50
@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build [Feature] Scan [Feature] SEO Tools Tools for improving a site's search engine optimization. [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Package] Newsletter [Package] Scan [Package] Seo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant