Skip to content

Premium analytics: remove token fallbacks - #50566

Merged
simison merged 8 commits into
trunkfrom
update/premium-analytics-no-token-fallbacks
Jul 16, 2026
Merged

Premium analytics: remove token fallbacks#50566
simison merged 8 commits into
trunkfrom
update/premium-analytics-no-token-fallbacks

Conversation

@simison

@simison simison commented Jul 16, 2026

Copy link
Copy Markdown
Member

Follow-up to #50502, which removed token fallbacks for routes.

This removes fallbacks from components used within premium analytics route, but that aren't under routes folder directly.

No big difference in output bundles; the fallbacks were previously added manually, now they're just added as part of the build process:

8 incorrect manual fallback values removed — since wpds var was used already, these should not have actual affect on UI:

Token Before (removed) After
--wpds-border-radius-md 8px 4px
--wpds-border-width-focus 1.5px var(--wp-admin-border-width-focus, 2px)
--wpds-color-foreground-content-neutral-weak #646970, #757575, currentColor #707070
--wpds-color-stroke-surface-neutral-weak #e0e0e0 #f0f0f0 (theme)
--wpds-dimension-gap-md 16px 12px
--wpds-typography-font-weight-medium 500 499

Proposed changes

  • Remove token fallbacks from Premium Analytics folder; they're added at build time so there's no need to manually manage them, which is more work and risks incorrect ones.
  • Adds entire folder to linter "no fallbacks" linter.
  • Skips icons package (projects/packages/premium-analytics/packages/icons/*); linter ignores them, and they'd need a different solution.

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Smoke test premium analytics; no visual regressions.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Premium Analytics plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 16, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@simison
simison force-pushed the update/premium-analytics-no-token-fallbacks branch from 10e8493 to 87d619f Compare July 16, 2026 14:15

@retrofox retrofox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've tested the branch and didn't find any visual changes. Let's keep checking in on follow-ups and tweak it if needed 🚀

Thanks, Mikael 🙇‍♂️

@simison
simison merged commit 7629d80 into trunk Jul 16, 2026
73 checks passed
@simison
simison deleted the update/premium-analytics-no-token-fallbacks branch July 16, 2026 14:58
@github-actions github-actions Bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants