Skip to content

Activity Log: register wp-build polyfills so the admin bundle loads - #50557

Merged
dhasilva merged 3 commits into
trunkfrom
fix/activity-log-blank
Jul 16, 2026
Merged

Activity Log: register wp-build polyfills so the admin bundle loads#50557
dhasilva merged 3 commits into
trunkfrom
fix/activity-log-blank

Conversation

@dhasilva

@dhasilva dhasilva commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

  • The Activity Log admin bundle depends on the wp-theme script handle (introduced when @wordpress/ui was bumped 0.13 → 0.17 here, which now depends on @wordpress/theme). WordPress core does not register that handle, so WP_Scripts::do_items() silently dropped the entire bundle and the page rendered as an empty root node — no console error.
  • Register the wp-build polyfills on the Activity Log screen via WP_Build_Polyfills::register(), mirroring the pattern already used by Forms, Backup, and My Jetpack. The call runs in admin_init() (hooked to load-{page_suffix}), so it stays page-scoped and never touches other admin requests.
  • Added automattic/jetpack-wp-build-polyfills to the activity-log package's composer.json.

Note: this only affects trunk. The @wordpress/ui 0.17 bump is not part of the jetpack/branch-16.0.1 release (which still pins 0.13), so shipped Activity Log builds are unaffected.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • On a site running WordPress without Gutenberg active (e.g. WP 6.9.x), connect Jetpack as a user and ensure the Activity Log menu item is available.
  • Navigate to Jetpack → Activity Log (wp-admin/admin.php?page=jetpack-activity-log).
  • Confirm the page renders the full Activity Log UI — the searchable DataViews timeline with events, filters, and pagination — rather than a blank content area.
  • Optionally, view source / inspect the network panel and confirm both the activity-log build/index.js bundle and the wp-theme polyfill script are loaded.

The admin bundle depends on the wp-theme script handle (pulled in via
@wordpress/ui 0.17). WordPress core doesn't register that handle, so
WP_Scripts silently dropped the bundle and the page rendered as an empty
root node. Register the wp-build polyfills on the Activity Log screen so
the handle exists, mirroring forms/backup/my-jetpack.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@dhasilva dhasilva added the [Status] Needs Review This PR is ready for review. label Jul 15, 2026
@dhasilva dhasilva self-assigned this Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/activity-log-blank branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/activity-log-blank

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/activity-log/src/class-jetpack-activity-log.php 0/53 (0.00%) 0.00% 7 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@github-actions github-actions Bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 15, 2026
@dhasilva
dhasilva merged commit cab61e4 into trunk Jul 16, 2026
76 of 77 checks passed
@dhasilva
dhasilva deleted the fix/activity-log-blank branch July 16, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Activity Log [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant