Skip to content

Premium Analytics: Keep settings drawer above widget chrome in stories #50350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dognose24 merged 1 commit into from
Jul 9, 2026
Merged

Premium Analytics: Keep settings drawer above widget chrome in stories #50350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/premium-analytics/changelog/storybook-drawer-stacking
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Keep the widget settings drawer above widget chrome in dashboard Storybook stories.
9 changes: 9 additions & 0 deletions projects/packages/premium-analytics/widgets/stories/widget-dashboard-with-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,22 @@ export function WidgetDashboardWithWidget( {
* wp-admin viewport. Without a definite height the page collapses to its
* content height and the fixed-row-height grid resizes it back on every
* vertical widget resize, so the two oscillate and the grid flickers.
*
* `isolation: isolate` keeps dashboard-internal z-indexes (widget
* headers, resize handles) inside this box's stacking context. The
* settings drawer has no z-index of its own (`--wp-ui-drawer-z-index`
* defaults to `initial`), so without the isolation those `z-index: 1`
* elements escalate to the document level and paint over the
* body-portaled drawer — in the real dashboard the wp-admin shell
* provides this containing stacking context.
*/ }
<div
style={ {
blockSize: '100vh',
display: 'flex',
flexDirection: 'column',
inlineSize: '100%',
isolation: 'isolate',
overflowX: 'auto',
} }
>
Expand Down
Loading