-
Notifications
You must be signed in to change notification settings - Fork 891
feat(premium-analytics): resolve internal packages for build and types #49189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chihsuan
merged 9 commits into
trunk
from
wooa7s-1320-configure-workspace-and-typescript-for-internal-packages
Jun 5, 2026
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
00fed2d
feat(premium-analytics): add tsconfig paths and typecheck for interna…
chihsuan 20e6241
Potential fix for pull request finding
chihsuan 662c887
Potential fix for pull request finding
chihsuan d4da9ca
docs(premium-analytics): clarify internal-package naming and rename init
chihsuan 528458b
Merge branch 'trunk' into wooa7s-1320-configure-workspace-and-typescr…
chihsuan feeb212
docs(premium-analytics): revert internal-packages README section
chihsuan 2beeaa9
fix(premium-analytics): align route name with internal-package conven…
chihsuan 952a10c
Merge remote-tracking branch 'origin/trunk' into wooa7s-1320-configur…
chihsuan d810267
docs(premium-analytics): fix stale README reference in tsconfig comment
chihsuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
projects/packages/premium-analytics/changelog/add-internal-package-resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: added | ||
|
|
||
| Add a tsconfig paths alias and typecheck script so internal packages/* resolve for types/IDE, and document how to wire cross-package imports for the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| { | ||
| "extends": "jetpack-js-tools/tsconfig.base.json", | ||
| "compilerOptions": { | ||
| // Resolve cross-package imports between internal `packages/*` modules | ||
| // (`@jetpack-premium-analytics/<dir>`) to their TypeScript source for | ||
| // type-checking + IDE. The build resolves the same specifier separately (see | ||
| // README → "Internal packages"); this keeps tsc/esbuild and `tsgo` in sync. | ||
|
chihsuan marked this conversation as resolved.
Outdated
|
||
| "paths": { | ||
| "@jetpack-premium-analytics/*": [ "./packages/*/src" ] | ||
|
manzoorwanijk marked this conversation as resolved.
|
||
| } | ||
| }, | ||
| "include": [ "routes/**/*", "packages/**/*" ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.