Skip to content

gv_fake_camera: fix spurious 100 ms stall in the frame pacing loop #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rperez45 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

gv_fake_camera: fix spurious 100 ms stall in the frame pacing loop #1089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/arvgvfakecamera.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,10 @@ _thread (void *user_data)
do {
gint timeout_ms;

timeout_ms = (next_timestamp_us - g_get_real_time ()) / 1000LL;
/* Signed arithmetic: if next_timestamp_us is already in the past, an
* unsigned subtraction underflows and is clamped to a spurious 100 ms
* timeout, stalling the frame pacing. */
timeout_ms = ((gint64) next_timestamp_us - g_get_real_time ()) / 1000LL;
if (timeout_ms < 0)
timeout_ms = 0;
else if (timeout_ms > 100)
Expand Down