Plural views view_files/view_cells; view_file stays as the Anthropic-style single-file form - #887
Open
ncoop57 wants to merge 8 commits into
Open
Plural views view_files/view_cells; view_file stays as the Anthropic-style single-file form#887ncoop57 wants to merge 8 commits into
view_files/view_cells; view_file stays as the Anthropic-style single-file form#887ncoop57 wants to merge 8 commits into
Conversation
view_files for viewing several files in one callview_file takes several paths via *args
ncoop57
marked this pull request as draft
August 3, 2026 18:29
ncoop57
marked this pull request as ready for review
August 3, 2026 18:34
view_file takes several paths via *args*args
*argsview_files/view_cells; view_file stays as the Anthropic-style single-file form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Views take one or more targets under the plural name:
view_files(*paths, ...): each file shown under a# file <path>header when several, with any line range applied to each file separately; a single path renders bareview_cells(path, *cell_ids, ...): same treatment with# cell <id>headers; replaces theview_cellfunction (theNotebook.view_cellmethod is unchanged)view_filestays exactly as on main: the single-file form keeps the name and positionalstart_line/end_lineestablished by Anthropic's text editor tool, which models have seen a lot. The editskill Naming section states both the plural rule and this exception.Breaking change: the
view_cellfunction is renamed toview_cells(no alias), andstart_line/end_lineare keyword-only on the plural views.Changes
nbs/12_tools.ipynb:view_filesdelegates per path to the unchangedview_filenbs/13_nbio.ipynb: single-cell rendering moves to_view_cell;view_cellsloops*cell_ids(headers use resolved ids)fastcore/editskill.py: exports and Naming convention text updatedAll new tests run red-green.
Note for review: this branch predates main's
exec_cell/show_celladditions to13_nbio.ipynb, so the regeneratednbio.pycurrently shows them as removed; merging main into the branch will clear that from the diff.