Skip to content

Antalya 26.3: Iceberg client, handle namespaceExists error #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subkanthi wants to merge 8 commits into
base: antalya-26.3
Choose a base branch
from
+16 −4
Open

Antalya 26.3: Iceberg client, handle namespaceExists error #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9d5c434
Added handling of 409 namespacealreadyexists in createNamespaceIfNotE…
subkanthi Jun 16, 2026
d356334
Added handling of 409 namespacealreadyexists in createNamespaceIfNotE…
subkanthi Jun 16, 2026
105f729
rollback not required change
subkanthi Jun 16, 2026
9ea143f
set http_max_tries to 1 for createNamespaceIfNotExists
subkanthi Jun 16, 2026
c726c3f
Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…
subkanthi Jun 19, 2026
1b1bcab
Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…
subkanthi Jul 1, 2026
7b90126
Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…
subkanthi Jul 6, 2026
ca764a2
Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…
subkanthi Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/Databases/DataLake/RestCatalog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,14 +1053,15 @@ bool RestCatalog::getTableMetadataImpl(
return true;
}

void RestCatalog::sendRequest(const String & endpoint, Poco::JSON::Object::Ptr request_body, const String & method, bool ignore_result) const
void RestCatalog::sendRequest(const String & endpoint, Poco::JSON::Object::Ptr request_body, const String & method, bool ignore_result, std::optional<DB::ReadSettings> read_settings_override) const
{
std::ostringstream oss; // STYLE_CHECK_ALLOW_STD_STRING_STREAM
if (request_body)
request_body->stringify(oss);
const std::string body_str = DB::removeEscapedSlashes(oss.str());

const auto & context = getContext();
DB::ReadSettings read_settings = read_settings_override.value_or(context->getReadSettings());

DB::ReadWriteBufferFromHTTP::OutStreamCallback out_stream_callback;
if (!body_str.empty())
Expand All @@ -1082,7 +1083,7 @@ void RestCatalog::sendRequest(const String & endpoint, Poco::JSON::Object::Ptr r
auto wb = DB::BuilderRWBufferFromHTTP(url)
.withConnectionGroup(DB::HTTPConnectionGroupType::HTTP)
.withMethod(method)
.withSettings(context->getReadSettings())
.withSettings(read_settings)
.withTimeouts(DB::ConnectionTimeouts::getHTTPTimeouts(context->getSettingsRef(), context->getServerSettings()))
.withHostFilter(&context->getRemoteHostFilter())
.withHeaders(headers)
Expand Down Expand Up @@ -1117,7 +1118,16 @@ void RestCatalog::createNamespaceIfNotExists(const String & namespace_name, cons
{
ProfileEvents::increment(ProfileEvents::DataLakeRestCatalogCreateNamespace);
auto timer = DB::CurrentThread::getProfileEvents().timer(ProfileEvents::DataLakeRestCatalogCreateNamespaceMicroseconds);
sendRequest(endpoint, request_body);
DB::ReadSettings read_settings = getContext()->getReadSettings();
read_settings.http_max_tries = 1;

@subkanthi subkanthi Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldnt find a better way to stop retrying as the retries happen in sendRequest, adding to nonRetriable error codes will affect all http calls.

@ianton-ru ianton-ru Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http_max_retries is checked in ReadWriteBufferFromHTTP::doWithRetries.
try-catch block in this method set local variable is_retriable to false for some cases.
I think better to improve this way - add some hint or callback with additional logic, which errors are retriable.

@arthurpassos arthurpassos Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it is important to understand what the correct behavior should be. Either ClickHouse or ice-rest-catalog is doing something wrong. I don't think we should be getting namespace already exists in each commit we try to do.

Either ClickHouse is sending a request with wrong arguments or ice-rest-catalog is responding the wrong code.

sendRequest(endpoint, request_body, Poco::Net::HTTPRequest::HTTP_POST, false, read_settings);
Comment on lines +1121 to +1123
}
catch (const DB::HTTPException & e)
{
if (e.getHTTPStatus() == Poco::Net::HTTPResponse::HTTP_CONFLICT)
LOG_DEBUG(log, "Namespace {} already exists", namespace_name);
else
DB::tryLogCurrentException(log);
}
catch (...)
{
Expand Down
4 changes: 3 additions & 1 deletion src/Databases/DataLake/RestCatalog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <Databases/DataLake/ICatalog.h>
#include <Poco/Net/HTTPBasicCredentials.h>
#include <IO/ReadWriteBufferFromHTTP.h>
#include <IO/ReadSettings.h>
#include <IO/HTTPHeaderEntries.h>
#include <Interpreters/Context_fwd.h>
#include <base/defines.h>
Expand Down Expand Up @@ -217,7 +218,8 @@ class RestCatalog : public ICatalog, public DB::WithContext
const String & endpoint,
Poco::JSON::Object::Ptr request_body,
const String & method = Poco::Net::HTTPRequest::HTTP_POST,
bool ignore_result = false) const;
bool ignore_result = false,
std::optional<DB::ReadSettings> read_settings_override = std::nullopt) const;

VendedStorageCredentials getCredentialsAndEndpoint(Poco::JSON::Object::Ptr object, const String & location) const;

Expand Down
Loading