Skip to content

[PWGJE] Switch to the median rho when the integral value is less than 0#16926

Open
YubiaoWang wants to merge 1 commit into
AliceO2Group:masterfrom
YubiaoWang:master
Open

[PWGJE] Switch to the median rho when the integral value is less than 0#16926
YubiaoWang wants to merge 1 commit into
AliceO2Group:masterfrom
YubiaoWang:master

Conversation

@YubiaoWang

Copy link
Copy Markdown
Contributor

Switch to the median rho instead of using zero when the local rho integral is zero.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Switch to the median rho when the integral value is less than 0 [PWGJE] Switch to the median rho when the integral value is less than 0 Jul 5, 2026
@alibuild

alibuild commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bbdc11e at 2026-07-05 23:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 14 warnings.'
Found 30 errors and 14 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/18d5743fd70514b27c66740bac59907649bcdfb9/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetChargedV2.cxx:55:8: error: constructor does not initialize these fields: detId, refAId, refBId, detIdCheck [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:151:31: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:153:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:183:24: error: initializer for member 'randomNumber' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:921:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:957:18: error: variable 'phiMinusPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:972:18: error: variable 'phiMinusPsi3' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1047:18: error: variable 'phiMinusPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1115:18: error: variable 'corrTagjetpt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1124:18: error: variable 'phiMinusPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1471:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1593:18: error: variable 'phiMinusPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1660:18: error: variable 'phiMinusPsi3' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1690:16: error: variable 'rcPhiPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1691:16: error: variable 'rcPhiPsi2Rand' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1719:81: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1725:85: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1741:91: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1750:87: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1763:85: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1908:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1980:18: error: variable 'phiMinusPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:1998:18: error: variable 'phiMinusPsi3' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2026:16: error: variable 'rcPhiPsi2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2032:81: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2045:91: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2054:98: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2068:85: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2235:9: error: Value stored to 'leadingJetPt' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGJE/Tasks/jetChargedV2.cxx:2302:13: error: variable 'tempparaA' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/18d5743fd70514b27c66740bac59907649bcdfb9/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetChargedV2.cxx:607:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:617:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:627:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:637:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:660:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:670:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:680:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:731:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:741:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetChargedV2.cxx:751:22: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

@YubiaoWang Please add info about which part of PWGJE is affected in the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants