Skip to content

feat(base64): add mimeTypes option - #1670

Open
mpryvkin wants to merge 6 commits into
Alex-D:developfrom
mpryvkin:feature-1477-base64-add-mime-types-option
Open

feat(base64): add mimeTypes option#1670
mpryvkin wants to merge 6 commits into
Alex-D:developfrom
mpryvkin:feature-1477-base64-add-mime-types-option

Conversation

@mpryvkin

Copy link
Copy Markdown
Contributor

add #1477

Comment thread plugins/base64/trumbowyg.base64.js Outdated
Comment thread plugins/base64/trumbowyg.base64.js Outdated
Comment thread plugins/base64/trumbowyg.base64.js Outdated
Comment thread plugins/base64/trumbowyg.base64.js Outdated
@mpryvkin
mpryvkin requested a review from Alex-D April 11, 2026 16:15

@Alex-D Alex-D left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside that, it seems legit :)

Comment thread docs/demos/plugins/base64.html Outdated
@Alex-D

Alex-D commented May 6, 2026

Copy link
Copy Markdown
Owner

Since I've merged another PR, you will need to fix conflicts :/

@mpryvkin
mpryvkin force-pushed the feature-1477-base64-add-mime-types-option branch from 1ecfd77 to 8213091 Compare May 26, 2026 02:57
@mpryvkin

Copy link
Copy Markdown
Contributor Author

@Alex-D, sorry for the delay, got sidetracked. Just rebased the commits to fix the conflicts. I noticed you prefer not to squash commits when merging, is that on purpose?

@mpryvkin
mpryvkin requested a review from Alex-D May 26, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants