Explicitly match on-the-fly HTLCs after a restart - #3357
Open
t-bast wants to merge 1 commit into
Open
Conversation
When we restart our node, we look at HTLCs that have been received but not relayed yet: they must be failed back, otherwise we would let them in the incoming channel until their timeout is reached, which would force our peer to force-close. There is an exception for HTLCs that are paying for an on-the-fly funded channel: we will explicitly retry relaying those HTLCs, even after a restart, because that's how we get paid for the funding fees. We were only matching them by `payment_hash`, which wasn't precise enough: an attacker could initiate an on-the-fly channel and then send unrelated HTLCs that use the same `payment_hash`, just to mess up with us and get some of our channels force-closed. We already have the detailed information about on-the-fly HTLCs in our DB, so we now use that to match HTLCs on the corresponding `channel_id` and `htlc_id`, which guarantees uniqueness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we restart our node, we look at HTLCs that have been received but not relayed yet: they must be failed back, otherwise we would let them in the incoming channel until their timeout is reached, which would force our peer to force-close.
There is an exception for HTLCs that are paying for an on-the-fly funded channel: we will explicitly retry relaying those HTLCs, even after a restart, because that's how we get paid for the funding fees. We were only matching them by
payment_hash, which wasn't precise enough: an attacker could initiate an on-the-fly channel and then send unrelated HTLCs that use the samepayment_hash, just to mess up with us and get some of our channels force-closed.We already have the detailed information about on-the-fly HTLCs in our DB, so we now use that to match HTLCs on the corresponding
channel_idandhtlc_id, which guarantees uniqueness.This was reported by Loupe (https://github.com/project-loupe).