Fix a batch of low-severity issues - #3355
Open
t-bast wants to merge 5 commits into
Open
Conversation
We used an explicit cast in our channel codec: this is safe for data that we created ourselves, but would throw an exception if our data is corrupted. It's trivial to be safe by removing the cast.
We require that encryption is used between the front and backend nodes in cluster mode, otherwise private data would be exposed. This protects node from messing up their deployment configuration without realizing it.
We don't return the exception message anymore for failed RPC calls, to avoid potentially leaking private information. This guarantees that only the node operator, with access to the logs, can see why RPC calls fail.
We don't support any TLV for onion messages yet. Since onion messages can be spammy, we don't need to waste any ressources trying to decode unknown TLVs that we'll throw away anyway.
t-bast
marked this pull request as ready for review
August 14, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several independent commits that fix low severity issues found by Loupe (https://github.com/project-loupe/). They are part of a defense-in-depth strategy and codebase clean-up, nothing in there is really dangerous.