Fix a batch of Tor-related issues - #3354
Open
t-bast wants to merge 3 commits into
Open
Conversation
In order to be valid, a Tor cookie must be exactly 32 bytes. We verify that and fail otherwise.
And fail if password mode is used but the host is remote.
t-bast
changed the title
There was a race condition in file permissions that allowed attackers on the machine to read secrets, because we started by creating the secret and only after that we set the file permissions. We now reverse that flow: we create an empty file with the right permissions and then write the secret to it. This applies to our seed files and to tor private keys.
t-bast
marked this pull request as ready for review
August 13, 2026 15:34
t-bast
commented
Aug 13, 2026
| Files.write(path.toPath, seed.toArray) | ||
| // Seed files derive the node identity key and all channel keys: they must never be readable by other local users. | ||
| setOwnerPermissions(path.toPath, "rw-------") | ||
| writeSecret(path.toPath, seed.toArray) |
Member
Author
rorp
reviewed
Aug 13, 2026
| override def receive: Receive = { | ||
| case Connected(_, _) => | ||
| case Connected(remoteAddress, _) => | ||
| checkControlAddress(remoteAddress) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several independent commits that fix low/medium severity issues for our Tor support found by Loupe (https://github.com/project-loupe/). Most of them require malicious infrastructure, so it's very likely that they haven't been exploited. They are rather part of a defense-in-depth strategy.
@rorp would appreciate your review 🙏