Add recommended_feerates optional message - #2860
Merged
Merged
Conversation
t-bast
force-pushed
the
recommended-feerates-message
branch
3 times, most recently
from
June 14, 2024 11:25
9271c1e to
6ad4d70
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
5 times, most recently
from
June 25, 2024 07:00
80c3f25 to
dd0ca58
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
from
June 27, 2024 15:09
dd0ca58 to
243ec46
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
3 times, most recently
from
July 8, 2024 09:56
ffb9e0f to
f8c7480
Compare
t-bast
marked this pull request as ready for review
July 8, 2024 14:57
t-bast
force-pushed
the
recommended-feerates-message
branch
from
July 9, 2024 15:04
f8c7480 to
b8da2e2
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
2 times, most recently
from
July 22, 2024 09:04
484554d to
a14de11
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
from
July 31, 2024 15:10
a14de11 to
d2988f6
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
2 times, most recently
from
August 28, 2024 08:03
afebf96 to
9c5c29b
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
5 times, most recently
from
September 9, 2024 09:52
fa82fce to
3c875aa
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
3 times, most recently
from
September 13, 2024 14:31
58b9ae8 to
1c7228b
Compare
t-bast
force-pushed
the
recommended-feerates-message
branch
from
September 24, 2024 01:43
1c7228b to
b287b59
Compare
We send to our peers an optional message that tells them the feerates we'd like to use for funding channels. This lets them know which values are acceptable to us, in case we reject their funding requests. This is using an odd type and will be automatically ignored by existing nodes who don't support that feature.
t-bast
force-pushed
the
recommended-feerates-message
branch
from
September 24, 2024 09:00
b287b59 to
8f26248
Compare
pm47
reviewed
Sep 24, 2024
pm47
reviewed
Sep 24, 2024
pm47
reviewed
Sep 24, 2024
* type `CurrentFeerates` based on source Feerates are highly subjective and it makes sense to type them based on the source, to remove ambiguity. We may typically use a more "standard" feerate source for commitment feerates, and a more "aggressive" feerate source for funding/closing feerates. * rename NodeParams.currentFeerates to currentBitcoinCoreFeerates
pm47
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We send to our peers an optional message that tells them the feerates we'd like to use for funding channels. This lets them know which values are acceptable to us, in case we reject their funding requests.
This is using an odd type and will be automatically ignored by existing nodes who don't support that feature.