Skip to content

fix(portals): live channels sidebar overwrites shell panel width in localStorage #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4gray merged 1 commit into from
Jul 4, 2026
Merged

fix(portals): live channels sidebar overwrites shell panel width in localStorage #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lker/feature/src/lib/stalker-live-stream-layout/stalker-live-stream-layout.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
[minWidth]="250"
[maxWidth]="600"
[defaultWidth]="400"
storageKey="sidebar-width"
storageKey="live-channels-sidebar-width"
>
<div class="sidebar-header category-content-header">
<div class="category-meta">
Expand Down
14 changes: 14 additions & 0 deletions ...r/feature/src/lib/stalker-live-stream-layout/stalker-live-stream-layout.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,20 @@ describe('StalkerLiveStreamLayoutComponent', () => {
expect(stalkerStore.setItvChannels).not.toHaveBeenCalled();
});

it('persists the channels sidebar width under a dedicated storage key', () => {
// The shell context panel (category sidebar) is visible at the same
// time as this sidebar and persists its width under the shared
// "sidebar-width" key. Reusing that key here makes the two panels
// overwrite each other's stored width across reloads.
fixture.detectChanges();

const sidebar: HTMLElement =
fixture.nativeElement.querySelector('.sidebar');
expect(sidebar.getAttribute('storageKey')).toBe(
'live-channels-sidebar-width'
);
});

it('keeps row previews empty before bulk epg is loaded', async () => {
fixture.detectChanges();
await fixture.whenStable();
Expand Down
2 changes: 1 addition & 1 deletion libs/portal/xtream/feature/src/lib/live-stream-layout/live-stream-layout.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[minWidth]="250"
[maxWidth]="600"
[defaultWidth]="400"
storageKey="sidebar-width"
storageKey="live-channels-sidebar-width"
>
<div class="sidebar-header">
<div class="category-heading">
Expand Down
15 changes: 15 additions & 0 deletions libs/portal/xtream/feature/src/lib/live-stream-layout/live-stream-layout.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,21 @@ describe('LiveStreamLayoutComponent', () => {
).toBeNull();
});

it('persists the channels sidebar width under a dedicated storage key', () => {
// The shell context panel (category sidebar) is visible at the same
// time as this sidebar and persists its width under the shared
// "sidebar-width" key. Reusing that key here makes the two panels
// overwrite each other's stored width across reloads.
selectedCategoryId.set(1);
fixture.detectChanges();

const sidebar: HTMLElement =
fixture.nativeElement.querySelector('.sidebar');
expect(sidebar.getAttribute('storageKey')).toBe(
'live-channels-sidebar-width'
);
});

describe('auto-open from Ctrl+F search navigation state', () => {
const searchChannel = {
xtream_id: 202,
Expand Down
Loading