Skip to content

Commit bfa6c19

Browse files
authored
chore: fix benchmark action (#4207)
repo currently contains a peerDependency on esLint that can't be fulfilled. Accept esLint ^10 with --legacy-peer-deps
1 parent 4cdec2d commit bfa6c19

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
- name: Setup js-framework-benchmark
6565
working-directory: js-framework-benchmark
6666
run: |
67-
npm ci
67+
npm ci --legacy-peer-deps
6868
npm run install-server
6969
npm run install-webdriver-ts
7070
@@ -79,16 +79,16 @@ jobs:
7979
- name: Build benchmark-struct app
8080
working-directory: yew/tools/benchmark-struct
8181
run: |
82-
RUSTFLAGS='--cfg getrandom_backend="wasm_js"' wasm-pack build \
82+
wasm-pack build \
8383
--release \
8484
--target web \
8585
--no-typescript \
8686
--out-name js-framework-benchmark-yew \
87-
--out-dir $STRUCT_BUILD_DIR
87+
--out-dir "$STRUCT_BUILD_DIR"
8888
8989
- name: Show built benchmark-struct benchmark files
9090
run: |
91-
ls -lauh js-framework-benchmark/frameworks/keyed/yew/bundled-dist/
91+
ls -lauh "$STRUCT_BUILD_DIR"
9292
9393
- name: Setup yew-hooks benchmark
9494
run: |
@@ -101,16 +101,16 @@ jobs:
101101
- name: Build benchmark-hooks app
102102
working-directory: yew/tools/benchmark-hooks
103103
run: |
104-
RUSTFLAGS='--cfg getrandom_backend="wasm_js"' wasm-pack build \
104+
wasm-pack build \
105105
--release \
106106
--target web \
107107
--no-typescript \
108108
--out-name js-framework-benchmark-yew-hooks \
109-
--out-dir $HOOKS_BUILD_DIR
109+
--out-dir "$HOOKS_BUILD_DIR"
110110
111111
- name: Show built benchmark-hooks benchmark files
112112
run: |
113-
ls -lauh js-framework-benchmark/frameworks/keyed/yew-hooks/bundled-dist/
113+
ls -lauh "$HOOKS_BUILD_DIR"
114114
115115
- name: Run js-framework-benchmark server
116116
working-directory: js-framework-benchmark

0 commit comments

Comments
 (0)