Skip to content

Commit df1d9df

Browse files
committed
fix race in test
1 parent 1662e94 commit df1d9df

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

tools/whnvmtool/Makefile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,10 @@ test-gen: $(OUT)
110110
rm -f whNvmImage.bin whNvmImage.hex
111111
./$(OUT) --test test/nvminit/test.nvminit --invert-erased-byte
112112

113-
# Run the negative tests, where invalid configs and key files must fail the tool
114-
test-invalid: $(OUT)
113+
# Run the negative tests, where invalid configs and key files must fail the tool.
114+
# Order-only prereq on test-gen: every whnvmtool instance binds the same TCP
115+
# port, so the two tool-running targets must not overlap under make -j.
116+
test-invalid: $(OUT) | test-gen
115117
./test/test_invalid_input.sh ./$(OUT)
116118

117119
# Run the test suite, which requires first generating the test NVM image

0 commit comments

Comments
 (0)