fix: don't gate platform port fields behind -deprecatedrpc=service on v23.1.x

The dashpay#7360 backport imported develop's `IsServiceDeprecatedRPCEnabled()` gate
around platformP2PPort/platformHTTPPort in CDeterministicMNStateDiff::ToJson,
and re-added the helper to evo/netinfo.{h,cpp} because it does not exist here.

That gate is dead on this release line. bbcd9d5 ("rpc: remove
-deprecatedrpc=service gating for service") removed gating on 23.x and left the
fields unenforced; upstream only restored it in dashpay#7181 (e50d436), which
targets the v24 line and is not an ancestor of this branch. Nothing on 23.x
passes -deprecatedrpc=service, and every sibling field (service in dmnstate.cpp,
and all of core_write.cpp) is emitted unconditionally here.

So on a default v23.1.8 node the condition was always false and both keys
disappeared entirely from protx diff/listdiff -- a regression against v23.1.7,
which emitted them unconditionally, and a contradiction of this release's own
notes promising they "report the corresponding non-zero values instead of stale
zeroes".

Emit them unconditionally, keeping dashpay#7360's actual fix (report the live port from
netInfo when the diff carries an ExtAddr netInfo). Drop the now-unused helper so
the branch does not carry a gate nothing can turn on.

Reported-by: knst
Co-Authored-By: Claude <noreply@anthropic.com>

Author: thepastaclaw

src/evo/dmnstate.cpp

@@ -87,24 +87,27 @@ UniValue CDeterministicMNStateDiff::ToJson(MnType nType) const
         if (fields & Field_platformNodeID) {
             obj.pushKV("platformNodeID", state.platformNodeID.ToString());
         }
-        if (IsServiceDeprecatedRPCEnabled()) {
-            // platformP2PPort/platformHTTPPort are deprecated scalar duplicates of netInfo's
-            // Platform entries. From ExtAddr onwards the scalar fields are unused (always 0), so
-            // when the diff carries an ExtAddr netInfo report the live port from it to stay
-            // consistent with the "addresses" output below.
-            const bool has_ext_netinfo = (fields & Field_netInfo) && state.netInfo->CanStorePlatform();
-            if (fields & Field_platformP2PPort) {
-                obj.pushKV("platformP2PPort",
-                           has_ext_netinfo && state.netInfo->HasEntries(NetInfoPurpose::PLATFORM_P2P)
-                               ? state.netInfo->GetEntries(NetInfoPurpose::PLATFORM_P2P)[0].GetPort()
-                               : state.platformP2PPort);
-            }
-            if (fields & Field_platformHTTPPort) {
-                obj.pushKV("platformHTTPPort",
-                           has_ext_netinfo && state.netInfo->HasEntries(NetInfoPurpose::PLATFORM_HTTPS)
-                               ? state.netInfo->GetEntries(NetInfoPurpose::PLATFORM_HTTPS)[0].GetPort()
-                               : state.platformHTTPPort);
-            }
+        // platformP2PPort/platformHTTPPort are deprecated scalar duplicates of netInfo's
+        // Platform entries. From ExtAddr onwards the scalar fields are unused (always 0), so
+        // when the diff carries an ExtAddr netInfo report the live port from it to stay
+        // consistent with the "addresses" output below.
+        //
+        // NOTE: unlike develop, v23.1.x does not gate these fields behind
+        // -deprecatedrpc=service. That gating was removed in bbcd9d543e6 and only restored
+        // upstream by #7181, which targets the v24 line and is not part of this release.
+        // Gating here would drop the fields entirely for every default node.
+        const bool has_ext_netinfo = (fields & Field_netInfo) && state.netInfo->CanStorePlatform();
+        if (fields & Field_platformP2PPort) {
+            obj.pushKV("platformP2PPort",
+                       has_ext_netinfo && state.netInfo->HasEntries(NetInfoPurpose::PLATFORM_P2P)
+                           ? state.netInfo->GetEntries(NetInfoPurpose::PLATFORM_P2P)[0].GetPort()
+                           : state.platformP2PPort);
+        }
+        if (fields & Field_platformHTTPPort) {
+            obj.pushKV("platformHTTPPort",
+                       has_ext_netinfo && state.netInfo->HasEntries(NetInfoPurpose::PLATFORM_HTTPS)
+                           ? state.netInfo->GetEntries(NetInfoPurpose::PLATFORM_HTTPS)[0].GetPort()
+                           : state.platformHTTPPort);
         }
     }
     {

src/evo/netinfo.cpp

@@ -70,12 +70,6 @@ bool IsAllowedPlatformHTTPPort(uint16_t port)
 
 bool IsNodeOnMainnet() { return Params().NetworkIDString() == CBaseChainParams::MAIN; }
 
-bool IsServiceDeprecatedRPCEnabled()
-{
-    const auto args = gArgs.GetArgs("-deprecatedrpc");
-    return std::find(args.begin(), args.end(), "service") != args.end();
-}
-
 const CChainParams& MainParams()
 {
     std::call_once(g_main_params_flag, [&]() { g_main_params = CreateChainParams(::gArgs, CBaseChainParams::MAIN); });

src/evo/netinfo.h

@@ -97,9 +97,6 @@ constexpr std::string_view PurposeToString(const NetInfoPurpose purpose)
     return "";
 }
 
-/** Identical to IsDeprecatedRPCEnabled("service"). For use outside of RPC code */
-bool IsServiceDeprecatedRPCEnabled();
-
 /** Will return true if node is running on mainnet */
 bool IsNodeOnMainnet();