feat(postgresflex): migrate to v3 API - #1505
Open
rubenhoenle wants to merge 6 commits into
Open
Conversation
rubenhoenle
marked this pull request as ready for review
July 29, 2026 13:31
relates to STACKITCLI-415
rubenhoenle
force-pushed
the
feat/postgresflex-v3-api
branch
from
July 29, 2026 13:31
477d84b to
1a8fed5
Compare
8 tasks
marceljk
reviewed
Jul 31, 2026
marceljk
reviewed
Jul 31, 2026
marceljk
reviewed
Jul 31, 2026
marceljk
reviewed
Jul 31, 2026
Merging this branch changes the coverage (11 decrease, 9 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
GokceGK
reviewed
Aug 4, 2026
| ListVersions(ctx context.Context, projectId, region string) postgresflex.ApiListVersionsRequest | ||
| GetInstance(ctx context.Context, projectId, region, instanceId string) postgresflex.ApiGetInstanceRequest | ||
| GetUser(ctx context.Context, projectId, region, instanceId, userId string) postgresflex.ApiGetUserRequest | ||
| } |
Contributor
There was a problem hiding this comment.
Client is not used anymore, we can remove it
GokceGK
reviewed
Aug 4, 2026
Comment on lines
40
to
72
| func GetInstanceReplicas(instanceType string) (int32, error) { | ||
| numReplicas, ok := instanceTypeToReplicas[instanceType] | ||
| if !ok { | ||
| return 0, fmt.Errorf("invalid instance type: %v", instanceType) | ||
| } | ||
| return numReplicas, nil | ||
| } | ||
|
|
||
| func GetInstanceType(numReplicas int32) (string, error) { | ||
| for k, v := range instanceTypeToReplicas { | ||
| if v == numReplicas { | ||
| return k, nil | ||
| } | ||
| } | ||
| return "", fmt.Errorf("invalid number of replicas: %v", numReplicas) | ||
| } | ||
|
|
||
| func ValidateFlavorId(flavorId string, flavors []postgresflex.Flavor) error { | ||
| func ValidateFlavorId(flavorId string, flavors []postgresflex.ListFlavors) error { | ||
| if flavors == nil { | ||
| return fmt.Errorf("nil flavors") | ||
| } | ||
|
|
||
| for _, f := range flavors { | ||
| if f.Id != nil && strings.EqualFold(*f.Id, flavorId) { | ||
| if strings.EqualFold(f.Id, flavorId) { | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| return &errors.DatabaseInvalidFlavorError{ | ||
| Service: "postgresflex", | ||
| Details: fmt.Sprintf("You provided flavor ID '%s', which is invalid.", flavorId), | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
GetInstanceReplicas, GetInstanceType and ValidateFlavorId functions are not used anymore. We can clean up
GokceGK
reviewed
Aug 4, 2026
| } | ||
| } | ||
|
|
||
| func TestGetInstanceType(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This test can be cleaned up after related util function is deleted
GokceGK
reviewed
Aug 4, 2026
| } | ||
| } | ||
|
|
||
| func TestValidateFlavorId(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This test can be cleaned up after related util function is deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-415
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)