[Phase 1] feat(chat): 법률 RAG 채팅 계약 테스트 추가 - #17

backend-ai/tests/test_agent_chat.py (1)

61-69: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Strengthen legal-card contract assertions to cover all standardized fields.

This test currently validates lawName, articleNo, and content, but not title and score, so schema regressions on those fields can slip through.

Proposed test tightening

     body = response.json()
     assert response.status_code == 200
     assert body["intent"] == "LEGAL_CONSULT"
     assert body["answer"]
     assert len(body["legalCards"]) >= 1
-    assert body["legalCards"][0]["lawName"] == "주택임대차보호법"
-    assert body["legalCards"][0]["articleNo"]
-    assert body["legalCards"][0]["content"]
+    card = body["legalCards"][0]
+    assert card["lawName"] == "주택임대차보호법"
+    assert card["articleNo"]
+    assert card["title"]
+    assert card["content"]
+    assert isinstance(card["score"], (int, float))

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend-ai/tests/test_agent_chat.py` around lines 61 - 69, The legal card
assertions in the test are incomplete and missing validation for the `title` and
`score` fields. Add assertions to verify that body["legalCards"][0]["title"] and
body["legalCards"][0]["score"] are present and valid, similar to how the
existing assertions check for lawName, articleNo, and content. This ensures all
standardized fields in the legal card schema are validated and prevents
regressions on these fields.

backend/src/test/java/com/ssafy/salmanhae/controller/chat/ChatControllerTest.java (1)

76-83: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Assert all standardized legal card fields in the Spring contract test.

The test currently checks lawName/articleNo only, but this contract’s standardized fields include title, content, and score too.

♻️ Proposed assertion additions

 				.andExpect(jsonPath("$.data.legalCards", hasSize(1)))
 				.andExpect(jsonPath("$.data.legalCards[0].lawName").value("주택임대차보호법"))
-				.andExpect(jsonPath("$.data.legalCards[0].articleNo").value("제3조의2"));
+				.andExpect(jsonPath("$.data.legalCards[0].articleNo").value("제3조의2"))
+				.andExpect(jsonPath("$.data.legalCards[0].title").value("보증금의 회수"))
+				.andExpect(jsonPath("$.data.legalCards[0].content").isNotEmpty())
+				.andExpect(jsonPath("$.data.legalCards[0].score").value(0.92));

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@backend/src/test/java/com/ssafy/salmanhae/controller/chat/ChatControllerTest.java`
around lines 76 - 83, The legal card assertions in the ChatControllerTest are
incomplete and only verify lawName and articleNo fields, but the contract
requires checking additional standardized fields. Add jsonPath assertions to the
andExpect chain to verify that legalCards[0].title and legalCards[0].content are
not empty, and that legalCards[0].score contains a valid numeric value. These
new assertions should follow the same pattern and be placed alongside the
existing lawName and articleNo assertions.

backend/src/main/java/com/ssafy/salmanhae/model/dto/chat/ChatResponse.java (1)

13-15: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Make properties deeply immutable in the compact constructor.

List.copyOf(properties) is shallow, so mutable Map elements can still be changed after DTO creation and leak into responses.

♻️ Proposed fix

 public ChatResponse {
-		properties = properties == null ? List.of() : List.copyOf(properties);
+		properties = properties == null
+				? List.of()
+				: properties.stream().map(Map::copyOf).toList();
 		legalCards = legalCards == null ? List.of() : List.copyOf(legalCards);
 	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend/src/main/java/com/ssafy/salmanhae/model/dto/chat/ChatResponse.java`
around lines 13 - 15, The current implementation of the compact constructor in
ChatResponse only creates a shallow immutable copy of the properties list using
List.copyOf(), which means the Map elements inside can still be mutated after
the DTO is created. To fix this and ensure deep immutability, modify the
properties assignment to iterate through each Map in the list, convert each Map
to an immutable copy using Map.copyOf() or Collections.unmodifiableMap(), and
then wrap the resulting collection in List.copyOf(). This ensures both the list
and all nested Map objects are immutable and cannot leak mutable state into
responses.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes